Repository navigation
0.0.5: snapshot(app) is exported, as docs/api.md states - #12
Merged
Merged
Conversation
The command tree that completion generation walks is reachable from an importer: a tool lists its own commands and options from the definition it parses with, instead of from a completion script's text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/api.md names
snapshot(app)as the function that builds thecompletions::Commandtree, but the module did not export it: an importer could reach the tree only through a completion script's text.snapshot(const App&)is declaredexportahead ofApp; its definition is unchanged.mcpp lists its own commands and options from this tree (
mcpp emit surface, mcpp#984).