Repository navigation
Fix day-only alarms never firing when night starts at midnight - #845
Merged
Merged
Conversation
Alarm activation used a day/night check that assumed night starts in the evening, so a night start at 00:00 made the whole day count as night and day-only alarms never fired. Both the activation and sound checks now use one shared isNight helper on AlarmConfiguration that handles a night start earlier than the day start.
marionbarker
approved these changes
Nov 22, 2026
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve by successful test build onto iOS 18.7.8 and iOS 27.2.1 test phone; and Claude review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Night starts set to 00:00 (or any time before Day starts), the check that decides whether an alarm may fire treated the whole day as night, so alarms set to Day never went off. The sound check already handled this case, so the two disagreed. Both now use a shared isNight helper on AlarmConfiguration. Unit tests cover the schedule itself and shouldFire for day and night alarms with a midnight night start.