Repository navigation
Conversation
A phone that joined with an invite or has no APN key of its own now starts the Live Activity locally once the hub shares an admin's key, and the hub updates and renews it. The app no longer tries push-to-start or shows the credentials notification in that case, and the APN screen stays editable so a key for remote control can be added. Remote settings exports carry the key that signs commands, and a same-team remote key becomes LoopFollow's own key on import and in a migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A phone that joined LF Hub with an invite, or has no APN key of its own, gets notifications through the key an admin shares. The Live Activity now works on such a phone: the app starts it locally once the hub reports the key as shared, and the hub updates and renews it. The app skips push-to-start and the credentials notification in that case, and the notification explains the Background Refresh choice when the phone leaves Hub mode. The APN screen shows that the key is shared by LF Hub and stays editable, since remote control signs with this phone's own key.
Remote settings exports carry the key that signs commands, so a phone of the same team gets LoopFollow's own key from them. An APN settings export carries its team and is refused by a LoopFollow built with another team. A same-team remote key becomes LoopFollow's own key on import and in migration step 11.