Repository navigation
Conversation
The bolus, meal and carb screens take the Nightscout id of the newest treatment LoopFollow had fetched when they open, and send it with the command as known-through-id to Loop and known_through_id to Trio, which use it to refuse a command if something was added that the caregiver had not seen. Trio bolus and meal commands carry a command id, and Loop commands expire 12 minutes after they are sent. Commands from the watch carry no id. Replies to remote commands stay in Notification Center while the app is open.
# Conflicts: # RemoteShared/PushMessage.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoopFollow now sends the Nightscout id of the newest treatment it had when the bolus, meal or carb screen was opened. Loop and Trio use it to refuse a command if something was added that the caregiver had not seen. Trio commands also get an id so they never run twice. Replies now stay in Notification Center when the app is open, so the reason for a refusal can be read. Older Loop and Trio ignore the new fields. Companion to LoopKit/LoopWorkspace#594 and nightscout/Trio#1789.