Repository navigation
Conversation
When creating a new on-chain wallet, we insert a first checkpoint as its birthday, but never persisted it explicitly. It only reached the store because filling the address pool later in the build happens to flush the wallet's staged changes. Without that side effect, a node restarted before its first sync would reload the wallet at genesis and try to rescan the whole chain, which never succeeds against a pruned bitcoind. We now persist the wallet right after applying the checkpoint, failing the build if that doesn't succeed, so the birthday no longer depends on unrelated wallet persistence. Reported-by: vnprclanker Co-Authored-By: HAL 9000
Nothing covered that a node restarted between its first build and its first wallet sync keeps the wallet birthday rather than rescanning from genesis. We add an integration test that builds a fresh node against bitcoind, drops it before it syncs, and checks that the rebuilt node doesn't pick up a payment confirmed before its birthday. Co-Authored-By: HAL 9000
|
👋 Thanks for assigning @tankyleo as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a new on-chain wallet, we insert a first checkpoint as
its birthday, but never persisted it explicitly. It only reached the
store because filling the address pool later in the build happens to
flush the wallet's staged changes. Without that side effect, a node
restarted before its first sync would reload the wallet at genesis and
try to rescan the whole chain, which never succeeds against a pruned
bitcoind.
We now persist the wallet right after applying the checkpoint, failing
the build if that doesn't succeed, so the birthday no longer depends
on unrelated wallet persistence.