Repository navigation
Conversation
`Builder::set_chain_source_esplora_with_headers` was only available to Rust users, so bindings users had no way to authenticate against an Esplora server that requires custom request headers. Export the method via UniFFI alongside the plain Esplora setter, as all of its arguments are already representable in the bindings. Co-Authored-By: HAL 9000
`Builder::enable_liquidity_provider` was only available to Rust users, even though `LSPS2ServiceConfig` is already a UniFFI record. Bindings users could therefore construct the service configuration but had no way to hand it to the builder. Export the method via UniFFI next to the other liquidity setter. Co-Authored-By: HAL 9000
`aggregate_channel_pair_stats` was only available to Rust users, so bindings users could list channel-pair forwarding buckets but had to reimplement the aggregation into cumulative totals themselves. Export it as a free function via UniFFI. Co-Authored-By: HAL 9000
`Node::prober` and `Prober::locked_msat` were only available to Rust users, so bindings users could configure background probing but had no way to observe how much liquidity is locked in in-flight probes. Make `Prober` a UniFFI object and export `locked_msat`. As bindings can't hold a borrowed reference, `Node::prober` hands out a shared handle when building with UniFFI. Co-Authored-By: HAL 9000
The bindings' `NodeAnnouncementInfo` dropped the announced feature bits and the node color when converting from LDK's type, so bindings users querying the network graph saw less than Rust users do. Carry both fields over, reusing the existing `NodeFeatures` object for the feature bits and passing the color as its three raw bytes. Co-Authored-By: HAL 9000
|
👋 Thanks for assigning @tankyleo as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We just expose some APIs that we so far missed to expose via
uniffi.