Skip to content

Drop direct chrono dependency - #1248

Open
tnull wants to merge 1 commit into
lightningdevkit:mainfrom
tnull:2026-11-drop-chrono-dependency
Open

tnull wants to merge 1 commit into
lightningdevkit:mainfrom
tnull:2026-11-drop-chrono-dependency

Conversation

@tnull

@tnull tnull commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

We depended on chrono only to format the log timestamps and to construct LSPSDateTime values through its public chrono field. As lightning-liquidity is about to stop using chrono and to make that field private, our direct dependency would be all that keeps the crate in the dependency tree.

Format log timestamps from the system clock ourselves and build LSPSDateTime values from a duration since the Unix epoch, which works both before and after the upstream change. The timestamp formatting is duplicated in the test loggers as integration tests can't reach crate-internal helpers.

We depended on `chrono` only to format the log timestamps and to
construct `LSPSDateTime` values through its public `chrono` field. As
`lightning-liquidity` is about to stop using `chrono` and to make that
field private, our direct dependency would be all that keeps the crate
in the dependency tree.

Format log timestamps from the system clock ourselves and build
`LSPSDateTime` values from a duration since the Unix epoch, which
works both before and after the upstream change. The timestamp
formatting is duplicated in the test loggers as integration tests
can't reach crate-internal helpers.

Co-Authored-By: HAL 9000
@tnull
tnull requested a review from tankyleo November 19, 2026 10:10
@ldk-reviews-bot

ldk-reviews-bot commented Nov 19, 2026 •

Copy link
Copy Markdown

👋 Thanks for assigning @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants