Repository navigation
Conversation
We depended on `chrono` only to format the log timestamps and to construct `LSPSDateTime` values through its public `chrono` field. As `lightning-liquidity` is about to stop using `chrono` and to make that field private, our direct dependency would be all that keeps the crate in the dependency tree. Format log timestamps from the system clock ourselves and build `LSPSDateTime` values from a duration since the Unix epoch, which works both before and after the upstream change. The timestamp formatting is duplicated in the test loggers as integration tests can't reach crate-internal helpers. Co-Authored-By: HAL 9000
|
👋 Thanks for assigning @tankyleo as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We depended on
chronoonly to format the log timestamps and to constructLSPSDateTimevalues through its publicchronofield. Aslightning-liquidityis about to stop usingchronoand to make that field private, our direct dependency would be all that keeps the crate in the dependency tree.Format log timestamps from the system clock ourselves and build
LSPSDateTimevalues from a duration since the Unix epoch, which works both before and after the upstream change. The timestamp formatting is duplicated in the test loggers as integration tests can't reach crate-internal helpers.