Repository navigation
Conversation
|
I've assigned @tnull as a reviewer! |
Camillarhi
suggested changes
Nov 17, 2026
Camillarhi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this. I left a few comments
Nit: the commit message says "losing handed addresses", but the addresses lost are pooled ones that were never handed out. Something like "skipping pooled derivation indices" would be more accurate. Also a double space in "decode persisted".
randomlogin
force-pushed
the
nov-26-fail-on-undecodable-address-pool
branch
from
November 17, 2026 22:19
ea4b91e to
0f9a345
Compare
Contributor
Author
|
Amended the commit. |
tnull
reviewed
Nov 18, 2026
tnull
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! To be honest I'm not fully sure hard failure is preferable here, but it is in-line with what we do elsewhere, so might as well keep it consistent for now.
Just a few nits.
Previously we continued the build after failing to decode the persisted `AddressPool`, which skipped the pooled derivation indices: they stayed revealed but were never handed out. Now we explicitly fail the build in that case. A missing record still starts a fresh pool, as for wallets that predate the pool.
randomlogin
force-pushed
the
nov-26-fail-on-undecodable-address-pool
branch
from
November 18, 2026 13:31
0f9a345 to
c272dfb
Compare
tnull
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1212.
As with other storage readings, we fail the build if we cannot read it (despite the fact that failing to read
AddressPoolis less severe than other failed readings).NotFoundstays a fresh pool: every node upgrading from v0.7.x has no record yet, and revealing fresh indices is correct for them.