Skip to content

Match the notifier's build step by exact name - #121

Open
yaito3014 wants to merge 1 commit into
mainfrom
notifier-exact-step-regex
Open

yaito3014 wants to merge 1 commit into
mainfrom
notifier-exact-step-regex

Conversation

@yaito3014

Copy link
Copy Markdown
Member

No description provided.

cpp-warning-notifier links each result to the first successful step
whose name matches STEP_REGEX. "Build .+" also matches any other step
named "Build ...", so adding one before "Build Tests" would silently
point the links at the wrong step. Anchor the pattern to the one step
that prints CPPWARNINGNOTIFIER_LOG_MARKER.
@cppwarningnotifier

Copy link
Copy Markdown
EnvironmentC++23C++26
irisClang22Debug✅success✅success
Release✅success✅success
GCC15Debug✅success✅success
Release✅success✅success
MSVC2026Debug✅success✅success
Release✅success✅success

@saki7 saki7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some alternative design choices were discussed on Discord. Depends on the actual decision chosen by @yaito3014, but if you feel this change is sufficient, this PR can be trivially self-merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants