Repository navigation
Row 1195: the Priority column keeps room for the pill and its caret in a wider font - #1904
Merged
Merged
Conversation
…ts caret at 1400 and 900 (a Mac font ran Medium outside its box) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS smoke run on the 1.3.1 cut found a Mac-only defect:
test_edit_cells_layoutfailed with "900 px, light: priority Medium runs outside its box". The Priority pill (Row 1195 S2) plus its caret was as wide as its cell with the Linux font, so a wider font overflowed it.test_edit_cells_layoutnow measures the spare width of every Priority cell at 1400 and 900, light and dark, and fails under 12 px. Before the change the same test measured 0 to 3 px spare for Medium on Linux.Checked here (Linux only; not run on macOS, the smoke run decides): ci_scan, test_edit_cells_layout, test_table_columns, test_work_items, all pass alone.
Not checked:
test_work_items_header(row 808, the suggestion list) timed out twice here after about 6 minutes under load; it did the same on an earlier head without this change.🤖 Generated with Claude Code