Repository navigation
feat(json): enumerate JSON object members (hpm_json_object_len/_key) - #799
Draft
hyperpolymath wants to merge 3 commits into
Draft
hyperpolymath wants to merge 3 commits into
hyperpolymath wants to merge 3 commits into
Conversation
Split from #798 on the owner's ruling. to_json materialises objects instead of returning None: hpm_json_object_len / hpm_json_object_key, lowered on Bun-ESM (one Object.keys snapshot per walk). Native targets need the matching hpm-json-rsr Zig exports; this PR waits for them, so no native build meets an unresolved symbol. Tests: tests/codegen-bun/json_object_keys (keys, nesting, escaped keys, own keys only, inherited enumerable key, non-finite values) and json_escapes (objects now convert). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDiosfvobXq67wbduuK
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
A Wasm module that imports json's externs (`use json::*`) now imports hpm_json_object_len and hpm_json_object_key as well: 13 hpm_json_* imports instead of 11, under the `json` module. A host supplying only the v0.3 set fails with a LinkError at instantiation (checked with Bun's WebAssembly on this commit). The spec now says so, and how a host can stub the two until hpm-json-rsr exports them. Answers the outside-diff finding on stdlib/json.affine in the CodeRabbit review of #798; the externs moved to this PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDiosfvobXq67wbduuK
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Depends on: #798
Split from #798 on the owner's ruling after review. That review found that the new object branch of
to_jsoncalls two externs with no Zig export yet, so a native build linkingto_jsonwould fail on unresolved symbols.What
hpm_json_object_lenandhpm_json_object_keyletto_jsonmaterialise objects; onmainit returnsNonefor them, the gapjson.affinedocuments.Object.keys(review: it was one per key).Why this waits
The matching
hpm-json-rsrZig exports (hpm_json_object_len,hpm_json_object_key) must land first, and the owner requires atoma to verify them before the consumer leaves alpha. This session could not run a downloaded Zig binary; Guix is being set up to provide Zig 0.15.2. A PR onhyperpolymath/hpm-json-rsrwill be linked here, and this stays a draft until it merges.Consumer:
metadatastician/consent-aware-inspectorpins this branch's head, because its manifest validation enumerates policy keys.Tests
tests/codegen-bun/json_object_keys: keys in order, nested round-trip, escaped keys, own keys only, an inherited enumerable key excluded, non-finite members rejected.json_escapes: objects now convert.Local runs on this branch:
dune runtestpasses 594 tests; the Bun harnesses pass (7 plus negative controls); the codegen-deno corpus passes 39 harnesses and the WASM corpus 38.Known, tracked separately:
to_jsonaccumulates withacc ++ [x](O(n²) for very large objects). The owner chose to fix that with an affine in-placepushin the stdlib, as its own PR.Commits are unsigned. This container's signing shim is inactive.
Generated by Claude Code