Skip to content

Small update to contribution notes - #888

Merged
brandonleekramer merged 4 commits into
mainfrom
Contributions
Nov 20, 2026
Merged

brandonleekramer merged 4 commits into
mainfrom
Contributions

Conversation

@idalithb

Copy link
Copy Markdown
Contributor
  • copy edits
  • @benface it automatically included changelog updates, should I expect this moving forward?

@idalithb
idalithb requested a review from a team February 26, 2025 19:18
@idalithb idalithb changed the title Small updated to contribution notes Small update to contribution notes Feb 26, 2025
@benface

benface commented Feb 27, 2025 •

Copy link
Copy Markdown
Contributor

it automatically included changelog updates, should I expect this moving forward?

Ah yes @idalithb, that's the fetch-remote-docs script doing that; it runs automatically before the build (EDIT: and before pnpm run dev 😱 which I didn't realize, but not anymore). You can always decide to not include those changes in your commits (feel free to discard them completely); it's a similar situation to what I explained here. Those remote content updates will still make their way to production because they will be fetched before CI/CD builds and deploy the docs, regardless of whether they are in git. I would say no big deal to include them either.

Comment thread CONTRIBUTING.md Resolved
Comment thread CONTRIBUTING.md Resolved
Comment thread CONTRIBUTING.md Resolved

@benface benface left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads so much better! Thank you! 🙌

idalithb and others added 2 commits February 27, 2025 15:02
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>

@itsjerryokolo itsjerryokolo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update this against main and resolve the conflicts? The 0.38.0 changelog entry is already present, so please preserve the current changelog, including the newer releases.

@brandonleekramer
brandonleekramer merged commit 1fabdd1 into main Nov 20, 2026
4 checks passed
@brandonleekramer
brandonleekramer deleted the Contributions branch November 20, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants