Repository navigation
Conversation
Coverage (unit tests)No unit baseline recorded in
Line and branch coverage from unit test reports. History is recorded in |
dkhawk
marked this pull request as ready for review
November 20, 2026 17:51
|
Here is the summary of possible violations 😱 DetailsThere is a possible violation for not having product prefix.
The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dedicated
:maps3d-robolectric-testingmodule (com.google.maps.android:maps3d-testing-robolectric) providing headless JVM Robolectric testing support for the Google Maps 3D SDK for Android (play-services-maps3d), decoupled from the 2D:robolectric-testingmodule.What's included
Maps3DRobolectricTestRunner: Registers all 8 Maps 3D shadows via Robolectric'sInjectorand bindsMaps3DClassInstrumentorto avoid splittingMap3DView's private 4-arg constructor (which otherwise triggers an ASMLabel.resolvecrash due to R8 outlining a theme branch acrossFrameLayout.<init>).ShadowMap3DView,ShadowGoogleMap3D,ShadowMarker,ShadowPolyline,ShadowPolygon,ShadowModel,ShadowPopover, andShadowUiControlSettings— tracking lifecycle, camera/fly animations, ID-keyed overlay upserts, removals, UI control placements, and click simulation.findMap3DView()/requireMap3DView(),createTestMap3DView(),getMap3DBlocking(),createTestMap3D(),withTestMap3D(), Kotlin.shadowextensions, andMaps3DShadows.shadowOf(...)for Java callers.Maps3DTruth.assertThat(googleMap3D)/GoogleMap3DSubject(hasMapMode,hasCameraCenterNear,hasCameraAltitudeWithin,hasMarker/hasPolyline/hasPolygon/hasModel,hasModelNear,hasNoOverlays, etc.).compileOnlydependencies, committedmaps3d-robolectric-testing.api, Dokka aggregation, Maven publishing (maps3d-testing-robolectric, with optional-PpublishVersionoverride for local Maven testing).Verification
./gradlew :maps3d-robolectric-testing:testDebugUnitTest :maps3d-robolectric-testing:lint spotlessApply apiCheck :docs:dokkaGeneratemavenLocal()with-PpublishVersion=1.0.0-rc03and verified againstgooglemaps-samples/android-maps3d-samples(kotlin-appandjava-appRobolectric tests).