Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
The Quick Start in
src/google/adk/integrations/redis/README.mdbuilds the agent withinstructions=(plural).LlmAgentforbids extra fields, so copying the snippet fails withValidationError: ... instructions Extra inputs are not permitted.Solution:
Use the real field name,
instruction=. One-line docs change.Testing Plan
Small documentation fix, so no unit tests were added.
Manual End-to-End (E2E) Tests:
Extracted the Quick Start block from the README on
main(1997a12) and ran it withgoogle-adk==2.14.1andredisinstalled (Python 3.13, no Redis server needed since nothing connects at construction):pydantic_core._pydantic_core.ValidationError: 1 validation error for LlmAgent / instructions / Extra inputs are not permittedAgent,RedisSessionServiceandRunnerall construct).LlmAgentonmainstill declares onlyinstruction: str | InstructionProvider. No other code or docs changed.