Repository navigation
scripts: own every built binary, check mktemp, clean up on a signal - #976
Open
tannevaled wants to merge 1 commit into
Open
tannevaled wants to merge 1 commit into
tannevaled wants to merge 1 commit into
Conversation
The script items of #974, left after #968: - rspec/run.sh built parsesweep at /tmp/parsesweep, shared by every checkout on the machine, the same class #968 fixed for rbgo. Both binaries now go into one mktemp directory the run deletes; PARSESWEEP still overrides. - A failed mktemp -d now stops the run in all three scripts. rubyspec/run.sh has no `set -e`, so RBGO used to become /rbgo. - oracle.sh runs under /bin/sh, which may be dash, and dash runs no EXIT trap on a signal. INT and TERM now exit explicitly (130, 143), so the EXIT trap removes the directory on an interrupt as well. - oracle.sh checks its arguments before building, so a usage error answers at once (exit 2) instead of after a compile. Checked: oracle.sh with no arguments and with a bare -e exits 2 without building; `oracle.sh -e 'p [1, 2, 3].sum'` agrees with all four implementations; rspec/run.sh runs end to end (DSL pass=10 fail=0) and its build directory is gone afterwards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #974: this does its four script items. The VM items stay open there.
Refs #975: fixes one of those VM items,
pwriteswallowing ENOSPC/EIO.Refs #968: finishes the class of problem that PR fixed for rbgo.
What changes
scripts/conformance/rspec/run.shbuiltparsesweepat a fixed/tmp/parsesweep, which every checkout on the machine shared. Both binaries now go into onemktemp -ddirectory that the run deletes.PARSESWEEPstill overrides it, and the variable is now documented.mktemp -dnow stops the run in all three scripts.rubyspec/run.shruns withoutset -e, soRBGOused to fall back to/rbgo.scripts/oracle.shruns under/bin/sh, which may be dash, and dash runs no EXIT trap on a signal. INT and TERM now exit explicitly (130, 143), so the EXIT trap also removes the directory when a run is interrupted.scripts/oracle.shchecks its arguments before building, so a usage error answers at once (exit 2) instead of after a compile.The audit also named
apps/run.sh. No such file exists in this repository.Checked
oracle.shwith no arguments, and with a bare-e: exit 2, nothing built.oracle.sh -e 'p [1, 2, 3].sum': all four implementations agree.rspec/run.shend to end: parse sweep run, DSL pass=10 fail=0. The build directory it printed no longer exists afterwards.bash -n/sh -non all three scripts.🤖 Generated with Claude Code