Repository navigation
CI: cache Rust dependencies, run the Rust suites with cargo-nextest, and split macOS public-product in two - #135
Open
agorischek wants to merge 2 commits into
Open
agorischek wants to merge 2 commits into
agorischek wants to merge 2 commits into
Conversation
agorischek
force-pushed
the
agorischek/ci-rules-lockfiles
branch
from
November 21, 2026 04:21
972cbb2 to
dc0b37f
Compare
agorischek
force-pushed
the
agorischek/ci-rust-speed
branch
from
November 21, 2026 04:21
7590917 to
97882ca
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Planner tests do not verify the new matrix include objects or their workflow-output serialization, leaving missing fields or incorrectly included jobs undetected.
1 open issue
What changed in this PR
This PR speeds up CI by caching Rust dependency builds, adopting cargo-nextest, and splitting macOS checks into parallel Rust and Node jobs. It extends the existing CI planner to supply named matrix entries while preserving the Linux check name.
Changes:
- Add Rust caching and nextest execution, including serialized .NET helper tests.
- Separate Rust and Node checks to avoid duplicate CLI Rust tests.
- Update matrix planning, schemas, test expectations, and contributor documentation.
| File | Description |
|---|---|
tools/scripts/ci-plan.mjs |
Serialize matrix include objects for workflow outputs. |
tools/cli/test/problems.test.ts |
Expand the split check script when verifying gate coverage. |
tools/cli/test/ci-plan.cases.json |
Update expected macOS job names. |
tools/cli/src/lib/ci-rules.schema.ts |
Define named matrix entries with input values. |
tools/cli/src/lib/ci-plan.ts |
Produce matrix include objects alongside job names. |
package.json |
Add nextest and separate shared checks from tests. |
docs/maintainers/runner-coverage.md |
Document parallel macOS coverage. |
CONTRIBUTING.md |
Describe nextest, caching, and the macOS split. |
.github/workflows/ci.yml |
Run named matrix entries and route checks by part. |
.github/workflows/actions.lock |
Lock the Rust cache action dependency. |
.github/ci-rules.schema.json |
Reflect the updated matrix schema. |
.github/ci-rules.json |
Define Linux and split macOS matrix entries. |
.github/actions/check/action.yml |
Configure caching, nextest, and partitioned checks. |
.config/nextest.toml |
Serialize tests that share the .NET helper output. |
Review effort: Balanced
…and split macOS public-product in two - .github/actions/check restores the dependencies' build output with Swatinem/rust-cache (keyed on the toolchain, Cargo.lock and the job's part; only pushes to main save it), and runs the Rust suites with cargo-nextest: `npm run test:rust:nextest` (nextest across the workspace, doctests, then the same rules coverage, rustfmt and Clippy as `npm run test:rust`). .config/nextest.toml keeps the .NET suites, which publish one shared helper, one at a time. - The CLI's Rust suites no longer run twice: `npm run check` is now `check:no-test` and `npm test`, and the action runs the Node suites without packages/cli's test script, whose Rust half the workspace run covers. - The action takes a `part`: all, rust or node. public-product's matrix entries in .github/ci-rules.json now carry `with` values for the workflow's matrix.include, and macOS runs as `macos-latest, Rust` and `macos-latest, Node` in parallel; Linux stays one job, `ubuntu-latest`. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…nclude objects included Copilot review on #135. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
agorischek
force-pushed
the
agorischek/ci-rust-speed
branch
from
November 21, 2026 04:33
97882ca to
33c3585
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Stacked on #134. This is step (d), the two speed-ups.
.github/actions/checknow usesSwatinem/rust-cache@v2.9.3(locked inactions.lock).Cargo.lockand the job's part.mainsave the cache (save-if); pull requests restoremain's.public-product (macos-latest)compiles all 909 crates from scratch.npm run test:rust:nextest: nextest across the workspace, then doctests, then the rules coverage, rustfmt and Clippy thatnpm run test:rustalso runs. Locally,npm run test:rustis unchanged..config/nextest.tomlputs the three .NET native suites in a one-at-a-time group. They publish a shared helper "once per run" with aOnce, which under nextest's process-per-test means once per test, into one directory.public-productrancargo test -p projections-cliinsidenpm test, then again innpm run test:rust. Nownpm run checkischeck:no-test && npm test, and the action runs the Node suites withoutpackages/cli's script, then the CLI's Node tests directly.problems.test.tsfollows the split.part: all | rust | node.public-product's matrix entries in.github/ci-rules.jsongainnameandwith(the schema changes fromvalue). The workflow usesmatrix.includeandname: public-product (${{ matrix.name }}).public-product (ubuntu-latest), with the same check name.public-product (macos-latest, Rust)(build, then nextest and the Rust checks) andpublic-product (macos-latest, Node)(static checks, build, types, lint, Node suites, installed-CLI proofs, action e2e, tools doctor), running in parallel.ci-ok, so the renamed macOS checks don't matter there.docs/maintainers/runner-coverage.md.This PR changes
package.json,.config/and CI files, so it runs everything, including both macOS parts. Its run is the measurement against the about 53 minutes of today's macOS job. The first runs restore no cache until a push tomainsaves one.