Repository navigation
CI rules: embedded docs run the Linux checks alone; macOS for OS-specific code; the harness for what it tests - #133
Open
agorischek wants to merge 2 commits into
Open
agorischek wants to merge 2 commits into
agorischek wants to merge 2 commits into
Conversation
agorischek
force-pushed
the
agorischek/ci-rules-narrower
branch
from
November 21, 2026 04:06
559e1df to
366e404
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Host-only changes now skip the Linux harness and macOS WebKit jobs, leaving Inspector stage and RendererFrame coverage gaps that need explicit reachability rules and host-only test cases.
1 open issue
What changed in this PR
This PR refines the declarative CI rules introduced in #132 to reduce unnecessary jobs while preserving targeted checks.
Changes:
- Adds a
checksfile effect so embedded or generator-related Markdown runs only Linux checks. - Restricts macOS product checks to Rust, the Action definition, and CLI packaging scripts.
- Removes the renderer harness’s broad CLI trigger and adds selection cases for the revised rules.
| File | Description |
|---|---|
tools/cli/test/ci-plan.cases.json |
Adds cases for documentation, platform, and harness selection. |
tools/cli/src/lib/ci-rules.schema.ts |
Defines the new checks effect. |
tools/cli/src/lib/ci-files.ts |
Prevents checks files from marking reader crates as changed. |
CONTRIBUTING.md |
Documents Linux-checks-only classification. |
.github/ci-rules.schema.json |
Updates the generated schema for checks. |
.github/ci-rules.json |
Revises documentation, macOS, and harness selection rules. |
Review effort: Balanced
…r OS-specific code; the harness for what it tests Three rule changes in .github/ci-rules.json: - Markdown a crate embeds or a generator reads or writes (help text, agent prompts, reference and built-in pages) runs only the Linux check, which runs every crate's tests and generator's check, instead of counting as a change to the CLI: a new `checks` file effect. - macOS public-product runs only for files tagged os-specific: Rust sources, manifests and toolchain, action.yml and packages/cli/scripts/**. - The renderer harness runs when what it tests changes (renderers, kit, SDK and protocol, schemas, the Engine's Wasm build), not for every CLI change: the CLI's backend only serves it fixtures. Over the last 40 merged pull requests, 1,144 jobs become 973; the open documentation pull request #97 goes from 26 jobs to 4. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ws renderers in Copilot review on #133: a change to packages/host/core or packages/host/inspector reaches the harness through the Inspector's stage; CLI-only changes still don't. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
agorischek
force-pushed
the
agorischek/ci-rules-narrower
branch
from
November 21, 2026 04:21
366e404 to
f94e8e6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Stacked on #132. This is step (b): three rule changes in
.github/ci-rules.json, each with table cases.Documentation that crates embed runs only the Linux check. Markdown that a crate embeds or a generator reads or writes runs only Linux
public-product, which runs every crate's tests and every generator's check. It no longer counts as a CLI change. This covers help text, agent prompts (docs/agents), and reference and built-in pages. It uses a newchecksfile effect. Templates, such aspackages/cli/templates/SKILL.md, are still their crate's change.macOS runs only for OS-specific code. Before, it ran for any code outside a browser. Now macOS
public-productruns only for files taggedos-specific:action.yml;packages/cli/scripts/**.Windows is unchanged.
The renderer harness runs for what it tests. That means the renderers, the kit, the renderer SDK and protocol, the schemas, and the Engine's Wasm build. It no longer runs for every CLI change, since the CLI's backend only serves it fixtures. The Inspector still runs for CLI changes, because it explores and extracts through the CLI.
Measured by replaying the file lists of the last 40 merged PRs through the rules from #132 and from this PR: 1,144 jobs become 973. Examples:
Half of the 40 were full runs, mostly lockfile changes, which (c) targets.