Repository navigation
Portable schema types - #882
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The resolver changes reflection-based generic type and assembly-loading behavior across net48 and net10, but both target runtimes cannot be executed here, so human validation of the schema-loading path is needed.
No open issues 🎉
What changed in this PR
This PR improves offline schema type resolution so saved context schemas remain portable between .NET and .NET Framework runtimes.
Changes:
- Adds fallback assembly and type resolution for differing runtime identities, including generic types.
- Adds regression tests for core, framework, generic, array, and unknown type names.
- Registers the new tests and documents the fix in the release notes.
| File | Description |
|---|---|
| tests/SqlProvider.Tests/SqlProvider.Tests.fsproj | Registers the schema type resolution tests in the test project. |
| tests/SqlProvider.Tests/SchemaTypeNameTests.fs | Adds regression coverage for portable resolution of core, framework, generic, array, and unknown schema types. |
| src/SQLProvider.Common/Utils.fs | Adds portable assembly-qualified type resolution with fallback handling across runtime-specific assembly identities. |
| docs/RELEASE_NOTES.md | Documents the portable context schema type loading fix. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the offline type fetching of the context schema type loading