Skip to content

Portable schema types - #882

Merged
Thorium merged 2 commits into
fsprojects:masterfrom
Thorium:portable-schema-types
Nov 19, 2026
Merged

Thorium merged 2 commits into
fsprojects:masterfrom
Thorium:portable-schema-types

Conversation

@Thorium

@Thorium Thorium commented Nov 19, 2026

Copy link
Copy Markdown
Member

This PR improves the offline type fetching of the context schema type loading

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The resolver changes reflection-based generic type and assembly-loading behavior across net48 and net10, but both target runtimes cannot be executed here, so human validation of the schema-loading path is needed.

No open issues 🎉

What changed in this PR

This PR improves offline schema type resolution so saved context schemas remain portable between .NET and .NET Framework runtimes.

Changes:

  • Adds fallback assembly and type resolution for differing runtime identities, including generic types.
  • Adds regression tests for core, framework, generic, array, and unknown type names.
  • Registers the new tests and documents the fix in the release notes.
File Description
tests/​SqlProvider.Tests/​SqlProvider.Tests.fsproj Registers the schema type resolution tests in the test project.
tests/​SqlProvider.Tests/​SchemaTypeNameTests.fs Adds regression coverage for portable resolution of core, framework, generic, array, and unknown schema types.
src/​SQLProvider.Common/​Utils.fs Adds portable assembly-qualified type resolution with fallback handling across runtime-specific assembly identities.
docs/​RELEASE_NOTES.md Documents the portable context schema type loading fix.

Review effort: Lite

@Thorium
Thorium merged commit af9e981 into fsprojects:master Nov 19, 2026
3 checks passed
@Thorium
Thorium deleted the portable-schema-types branch November 19, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants