Repository navigation
fix: keyset pagination builds a key object for every row - #2756
Merged
Merged
Conversation
- doctrine and postgresql adapters compare raw key values per row - KeyValues built only for head, cursor, lookahead and errors - postgresql key names resolved once per page - streaming guide numbers updated Closes #2748
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2756 +/- ##
============================================
Coverage 91.10% 91.10%
- Complexity 0 32372 +32372
============================================
Files 2242 2242
Lines 93501 93524 +23
============================================
+ Hits 85186 85209 +23
Misses 8315 8315 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2748
Change Log
Added
Fixed
flow-php/etl-adapter-doctrine- keyset pagination built a key object for every rowflow-php/etl-adapter-postgresql- keyset pagination built a key object and parsed the key name for every rowChanged
Removed
Deprecated
Security