Skip to content

fix: keyset pagination builds a key object for every row - #2756

Merged
norberttech merged 1 commit into
1.xfrom
keyset-pagination-performance
Nov 20, 2026
Merged

norberttech merged 1 commit into
1.xfrom
keyset-pagination-performance

Conversation

@norberttech

Copy link
Copy Markdown
Member

Resolves: #2748

Change Log


Added

Fixed

  • flow-php/etl-adapter-doctrine - keyset pagination built a key object for every row
  • flow-php/etl-adapter-postgresql - keyset pagination built a key object and parsed the key name for every row

Changed

Removed

Deprecated

Security

- doctrine and postgresql adapters compare raw key values per row
- KeyValues built only for head, cursor, lookahead and errors
- postgresql key names resolved once per page
- streaming guide numbers updated

Closes #2748
@norberttech norberttech added this to the 0.49.0 milestone Nov 20, 2026
@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.10%. Comparing base (90b6bf2) to head (53687c6).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##                1.x    #2756      +/-   ##
============================================
  Coverage     91.10%   91.10%              
- Complexity        0    32372   +32372     
============================================
  Files          2242     2242              
  Lines         93501    93524      +23     
============================================
+ Hits          85186    85209      +23     
  Misses         8315     8315              
Components Coverage Δ
etl 96.24% <ø> (ø)
cli 87.40% <ø> (ø)
lib-array-dot 96.52% <ø> (ø)
lib-azure-sdk 69.50% <ø> (ø)
lib-doctrine-dbal-bulk 94.44% <ø> (ø)
lib-filesystem 89.10% <ø> (ø)
lib-types 94.64% <ø> (ø)
lib-parquet 82.80% <ø> (ø)
lib-parquet-viewer 83.15% <ø> (ø)
lib-snappy 89.86% <ø> (ø)
lib-dremel 0.00% <ø> (ø)
lib-postgresql 90.55% <ø> (ø)
lib-telemetry 86.85% <ø> (ø)
bridge-filesystem-async-aws 96.85% <ø> (ø)
bridge-filesystem-azure 95.66% <ø> (ø)
bridge-filesystem-sftp 90.29% <ø> (ø)
bridge-monolog-http 96.84% <ø> (ø)
bridge-monolog-telemetry 92.85% <ø> (ø)
bridge-openapi-specification 91.95% <ø> (ø)
symfony-http-foundation 80.76% <ø> (ø)
bridge-symfony-console 98.01% <ø> (ø)
bridge-psr18-telemetry 100.00% <ø> (ø)
bridge-psr3-telemetry 98.95% <ø> (ø)
bridge-psr7-telemetry 100.00% <ø> (ø)
bridge-telemetry-otlp 90.11% <ø> (ø)
bridge-symfony-http-foundation-telemetry 92.85% <ø> (ø)
bridge-symfony-filesystem-bundle 93.19% <ø> (ø)
bridge-symfony-filesystem-cache 98.18% <ø> (ø)
bridge-symfony-postgresql-bundle 93.72% <ø> (ø)
bridge-symfony-postgresql-cache 94.41% <ø> (ø)
bridge-symfony-postgresql-messenger 98.80% <ø> (ø)
bridge-symfony-postgresql-session 93.65% <ø> (ø)
bridge-symfony-telemetry-bundle 90.76% <ø> (ø)
adapter-chartjs 82.46% <ø> (ø)
adapter-csv 97.68% <ø> (ø)
adapter-doctrine 95.19% <100.00%> (+0.05%) ⬆️
adapter-google-sheet 97.53% <ø> (ø)
adapter-http 87.40% <ø> (ø)
adapter-json 90.62% <ø> (ø)
adapter-logger 47.05% <ø> (ø)
adapter-parquet 96.95% <ø> (ø)
adapter-text 97.68% <ø> (ø)
adapter-xml 98.01% <ø> (ø)
adapter-avro 6.25% <ø> (ø)
adapter-excel 96.79% <ø> (ø)
adapter-postgresql 97.38% <100.00%> (+0.03%) ⬆️
adapter-seal 90.00% <ø> (ø)
bridge-phpunit-postgresql 75.30% <ø> (ø)
bridge-phpunit-telemetry 87.36% <ø> (ø)
bridge-phpstan-types 0.00% <ø> (ø)
bridge-postgresql-valinor 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech
norberttech merged commit 573fb43 into 1.x Nov 20, 2026
22 checks passed
@norberttech
norberttech deleted the keyset-pagination-performance branch November 20, 2026 17:06
@github-project-automation github-project-automation Bot moved this from Todo to Done in Roadmap Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Keyset pagination builds and compares a key object for every row

1 participant