Repository navigation
engine: fix the 29.8 API version and add 29.9 and 29.10 to the matrix - #26694
Merged
Merged
Conversation
The 29.8 row of the API version matrix links to the v1.56 reference but labels it 1.55. The daemon in docker-v29.8.0 through docker-v29.8.2 sets MaxAPIVersion to "1.56" in daemon/config/config.go. Signed-off-by: Cory Snider <csnider@mirantis.com>
daemon/config/config.go sets MaxAPIVersion to "1.56" in docker-v29.9.0 through docker-v29.9.3, and to "1.57" in docker-v29.10.0. Both keep defaultMinAPIVersion at "1.40". Signed-off-by: Cory Snider <csnider@mirantis.com>
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The API version matrix on the Engine API reference page labelled the wrong maximum API version for 29.8, and it had no rows for 29.9 or 29.10.
MaxAPIVersionto 1.56 indaemon/config/config.go.I checked every other row against the API version constants at the first and last patch release of each version: the moby tags, plus the
-cetags for 17.03 through 18.09. They all match. Each row's label, version page link, and changelog anchor agree, and every linked page exists.Reviews
I used Claude Code to check the rows against the release tags and to draft both commits.
Created with: Claude Code