Repository navigation
Conversation
Every split on the desktop playground still flashed the other terminals blank in Chrome. The Lath animator signals settlement from inside its requestAnimationFrame callback, and TerminalPane fit there. In Chromium's TreesInViz compositor (crbug.com/454680865) an entering pane's first resize inside that callback makes Viz skip draws, so every other WebGL terminal canvas shows blank until something forces a fully damaged frame. #1839 moved WebGL acquisition after the first fit, which turned a lasting blank into a 130 ms - 2 s flash that 1 s samples missed. TerminalPane now runs the coordinator-woken fit and its mount fit from a zero-delay task. Measured from CDP screencast frames on the desktop playground: Chrome for Testing 150 (TreesInViz on by default) blanked all three existing terminals on every split, now none in 12 splits; Chrome 157 with --enable-features=TreesInViz likewise, now none in 15. Without TreesInViz, or on the DOM renderer, it never blanked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
b898c2c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://253fb541.mouseterm.pages.dev |
| Branch Preview URL: | https://chrome-flash.mouseterm.pages.dev |
dormouse-bot
approved these changes
Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every split on the desktop playground still flashed the other terminals blank in Chrome, even after #1839.
Cause
The Lath animator reports that a split has settled from inside its
requestAnimationFramecallback, andTerminalPaneran its fit right there. When an entering pane's first resize (away from xterm's default 80×24) happens inside that callback, Chromium's TreesInViz compositor failshas_damage(crbug.com/454680865: "Has no damage while expects_to_draw is set") and skips draws. Every other WebGL terminal canvas shows blank until something forces a fully damaged frame. #1839 moved WebGL acquisition after the first fit, which shortened a lasting blank to a 130 ms–2 s flash; its 1 s samples missed that.The entering pane's renderer doesn't matter: kept on the DOM renderer, it still blanked the others for about 2 s. Deferring the fit to the next animation frame still blanked; a
setTimeout(0)task did not.Fix
TerminalPaneruns the fit the coordinator wakes, and its mount-time fit (previously arequestAnimationFrame), from a zero-delay task. The WebGL-after-first-fit gate from Acquire a pane's WebGL renderer after its first settled fit #1839 stays.docs/specs/layout.md→ Renderer: Must fit a mounted pane from a task of its own, never inside an animation-frame callback. The rationale entry corrects the Acquire a pane's WebGL renderer after its first settled fit #1839 paragraph and adds the dated measurements. The word budget is ratcheted 7750 → 7800.Evidence
Counted from CDP
Page.startScreencastframes on the desktop playground, per pane:--enable-features=TreesInViz--disable-features=TreesInVizZoom, unzoom, and minimize/reattach still don't blank. No xterm rollback is needed: the current pins are clean once the fit moves to a task.
Testing
TerminalPane.test.tsxcase checks that no fit or renderer acquisition happens inside an animation-frame callback during a split; it fails against the old code.pnpm testin lib (includingtsc -b) and website,pnpm lint:specs, andpnpm lint:mdpass.🤖 Generated with Claude Code