Repository navigation
Conversation
The prompt draws inside its pane's body, so no other pane's view can sit over it. Hiding them all let a page in one pane freeze, and take the keyboard from, the page the user was typing in. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
5b20b64
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5a051a0e.mouseterm.pages.dev |
| Branch Preview URL: | https://webview-dialog-own-pane.mouseterm.pages.dev |
dormouse-bot
approved these changes
Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A page's
alert,confirm, orprompt, and the refused-download notice, now hide only their own pane's webview. Before, each hid every pane webview in the window, as a modal does.Why
With two webview panes side by side, a page in the pane you are not using could call
alert()from a timer. Its prompt froze the page you were typing in to a still and took its keyboard until you answered, and a page could repeat that at will. The review of #1852 raised this and suggested refusing a dialog from any pane but the one in passthrough. That would silently decline a legitimateconfirmfrom a page you started and then left for a terminal, so this takes the narrower fix.Security rule S308
The rule exists because a native view paints above the DOM, so a page left showing over a prompt could imitate it. This prompt draws inside its own pane's body, and the only view that can sit over that is the pane's own, which the panel still hides in the same commit that mounts the prompt.
docs/specs/security-local.mdnow says so, anddocs/specs/webview-pane.md-> "Visibility" names the exception. A modal, menu, or the new-tab prompt still hides every view.Verified
WebviewPanel.test.tsx: a dialog and the download notice each hide their own view and leave the shared occlusion off. Removing either condition fails a test.pnpm test:checks,tsc -b, spec and markdown lints pass.🤖 Generated with Claude Code