Skip to content

dsl: Ensure consistency in dimension lowering, add API to specify when a dimension should be lowered as a global index - #3117

Open
EdCaunt wants to merge 1 commit into
mainfrom
manual-global-index
Open

EdCaunt wants to merge 1 commit into
mainfrom
manual-global-index

Conversation

@EdCaunt

@EdCaunt EdCaunt commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

#3106 broke halo=0 with MPI. I've introduced a new GlobalIndex which can be accessed through a x.global_index shortcut for situations where users genuinely need a global index.

…n a dimension should be lowered as a global index
@FabioLuporini

Copy link
Copy Markdown
Contributor

when is it that they do NOT need a global index?

@mloubout mloubout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know where this comes from but forcing those "global vs local" on the user API is not good. I don't see why this is needed

@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.81481% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.24%. Comparing base (8370ce8) to head (7764fcb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_mpi.py 29.62% 19 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3117   +/-   ##
=======================================
  Coverage   84.24%   84.24%           
=======================================
  Files         260      260           
  Lines       59431    59503   +72     
  Branches     5019     5025    +6     
=======================================
+ Hits        50068    50131   +63     
- Misses       8524     8537   +13     
+ Partials      839      835    -4     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.31% <60.00%> (-0.02%) ⬇️
pytest-gpu-gcc- 79.00% <64.81%> (-0.01%) ⬇️
pytest-gpu-icx- 78.95% <64.81%> (+0.02%) ⬆️
pytest-gpu-nvc-nvidiaX 69.13% <60.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mloubout added a commit that referenced this pull request Nov 20, 2026
Restore RankOffset and test_rank_offset_empty, dropped by the previous commit.
The Grid index offsets io_x are now RankOffsets on the LEFT side rather than
plain Scalars, so that a single symbol carries the global index of a rank's
first point. They are evaluated per rank against the runtime Grid and keep
their name through SubDimension concretization.

Strengthen test_halo_zero_subdomain (from #3117) to compile on the distributed
Grid and compare against an explicitly zeroed reference, serial and on 4 ranks,
with and without transpose. On main it fails on 4 ranks, where the RankOffset
bounds of the halo=0 indicator are added on top of the global index offset.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants