Repository navigation
Conversation
…n a dimension should be lowered as a global index
Contributor
|
when is it that they do NOT need a global index? |
mloubout
requested changes
Nov 20, 2026
mloubout
left a comment
Contributor
There was a problem hiding this comment.
I don't know where this comes from but forcing those "global vs local" on the user API is not good. I don't see why this is needed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3117 +/- ##
=======================================
Coverage 84.24% 84.24%
=======================================
Files 260 260
Lines 59431 59503 +72
Branches 5019 5025 +6
=======================================
+ Hits 50068 50131 +63
- Misses 8524 8537 +13
+ Partials 839 835 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mloubout
added a commit
that referenced
this pull request
Nov 20, 2026
Restore RankOffset and test_rank_offset_empty, dropped by the previous commit. The Grid index offsets io_x are now RankOffsets on the LEFT side rather than plain Scalars, so that a single symbol carries the global index of a rank's first point. They are evaluated per rank against the runtime Grid and keep their name through SubDimension concretization. Strengthen test_halo_zero_subdomain (from #3117) to compile on the distributed Grid and compare against an explicitly zeroed reference, serial and on 4 ranks, with and without transpose. On main it fails on 4 ranks, where the RankOffset bounds of the halo=0 indicator are added on top of the global index offset.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3106 broke
halo=0with MPI. I've introduced a newGlobalIndexwhich can be accessed through ax.global_indexshortcut for situations where users genuinely need a global index.