Skip to content

misc: Add LIKWID to Dockerfile.cpu and ncu-report to Dockerfile.gpu - #3116

Open
FabioLuporini wants to merge 4 commits into
mainfrom
cpu-likwid
Open

FabioLuporini wants to merge 4 commits into
mainfrom
cpu-likwid

Conversation

@FabioLuporini

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread docker/Dockerfile.cpu Outdated

# LIKWID is used by DevitoProfiler to measure hardware counters on CPU backends
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
RUN curl -fsSL https://github.com/RRZE-HPC/likwid/archive/refs/tags/v5.5.2.tar.gz \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version are usually better as ENV/ARG to update it more easily without digging for every occurence.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment thread docker/Dockerfile.cpu Outdated
if [ "$(uname -m)" = aarch64 ]; then \
echo 'COMPILER=GCCARMv8' >> config.mk; fi && \
make -j "$(nproc)" && make install && \
install -Dm644 COPYING /usr/local/share/doc/likwid/COPYING && \

@mloubout mloubout Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing in /usr/local is not good for docker especialyl since we use builder images (that don't copy /usr, you need to configure to install in a path that is copied into the final image (like /opt)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@codecov

codecov Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.20%. Comparing base (1eb54aa) to head (ec2a701).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3116      +/-   ##
==========================================
- Coverage   84.20%   84.20%   -0.01%     
==========================================
  Files         260      260              
  Lines       59481    59481              
  Branches     5023     5023              
==========================================
- Hits        50085    50083       -2     
- Misses       8561     8563       +2     
  Partials      835      835              
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.33% <ø> (ø)
pytest-gpu-gcc- 78.96% <ø> (+<0.01%) ⬆️
pytest-gpu-icx- 78.79% <ø> (-0.09%) ⬇️
pytest-gpu-nvc-nvidiaX 69.15% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FabioLuporini

Copy link
Copy Markdown
Contributor Author

@mloubout should be good now

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants