Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3110 +/- ##
==========================================
- Coverage 84.20% 84.18% -0.02%
==========================================
Files 260 260
Lines 59481 59607 +126
Branches 5023 5031 +8
==========================================
+ Hits 50085 50182 +97
- Misses 8561 8588 +27
- Partials 835 837 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mloubout
force-pushed
the
mloubout/subgrid-rebuild
branch
2 times, most recently
from
November 13, 2026 02:37
563e80c to
3d7e391
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mloubout
force-pushed
the
mloubout/subgrid-rebuild
branch
2 times, most recently
from
November 13, 2026 14:58
b6d2e36 to
4fedfd3
Compare
FabioLuporini
approved these changes
Nov 13, 2026
mloubout
force-pushed
the
mloubout/subgrid-rebuild
branch
5 times, most recently
from
November 17, 2026 14:38
6321cce to
0412530
Compare
FabioLuporini
approved these changes
Nov 19, 2026
FabioLuporini
left a comment
Contributor
There was a problem hiding this comment.
looks OK, some minor nitpicks left but can go in
mloubout
force-pushed
the
mloubout/subgrid-rebuild
branch
2 times, most recently
from
November 19, 2026 17:16
55c8670 to
90ea252
Compare
mloubout
force-pushed
the
mloubout/subgrid-rebuild
branch
from
November 20, 2026 14:19
90ea252 to
98490b4
Compare
Restore RankOffset and test_rank_offset_empty, dropped by the previous commit. The Grid index offsets io_x are now RankOffsets on the LEFT side rather than plain Scalars, so that a single symbol carries the global index of a rank's first point. They are evaluated per rank against the runtime Grid and keep their name through SubDimension concretization. Strengthen test_halo_zero_subdomain (from #3117) to compile on the distributed Grid and compare against an explicitly zeroed reference, serial and on 4 ranks, with and without transpose. On main it fails on 4 ranks, where the RankOffset bounds of the halo=0 indicator are added on top of the global index offset.
EdCaunt
reviewed
Nov 20, 2026
The Grid index offsets io_x are now RankOffsets, which are uncached DataSymbols, so test_solve expects one fewer cached symbol, as before #3106. Review comments: * Retrieve the Dimensions with mode='unique' in _make_global_index_map * Return early from Distributor.subsample without domain decomposition * Make Distributor.size_map a frozendict * Make the Function size_map public * Merge the Function and TimeFunction _is_on_grid
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code generated with MPI on one rank (e.g. the DevitoPRO decoupler) now carries the global index and SubGrid offsets, and
Function._rebuild(grid=subgrid)moves onto the SubGrid's Dimensions.