Repository navigation
Conversation
…evelopit#115) '### 1. Agreement' rendered as '<h3><ol><li>Agreement</li></ol></h3>' because the heading branch re-parsed its contents with the full block parser, which treats a leading '1. ' as an ordered list. Headings can't contain blocks, so parse heading contents inline-only: a leading list/quote marker is kept as literal text and only the rest is parsed for inline formatting. Adds an internal 'inline' flag to parse(); the public two-argument call signature is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
### 1. Agreementrendered as<h3><ol><li>Agreement</li></ol></h3>instead of<h3>1. Agreement</h3>.Reproduced locally before the fix:
### 1. Agreement→<h3><ol><li>Agreement</li></ol></h3>### 2. Rights→<h3><ol><li>Rights</li></ol></h3>Root cause
The heading branch re-parsed its contents with the full block parser, which treats a leading
1.as an ordered list (same for-,>etc.).Fix
Headings can't contain blocks, so heading contents are now parsed inline-only (new internal
inlineflag onparse(); the public two-argument call signature is unchanged). A leading list/quote marker inside a heading is kept as literal text and only the rest is parsed for inline formatting, so### 1. **Agreement**still bolds correctly.Tests
npm test(eslint + mocha): 35 passing, including 2 new regression tests intest/index.jsunder 'titles'.