Repository navigation
fix(ci): pre-fetch Qwen tokenizer vocab with retries to deflake tests - #242
Merged
Merged
Conversation
The vocab download from ModelScope times out intermittently on GitHub runners, failing test_root_get_tokenizer_encodes_locally and the legacy tokenizer tests. Cache the vocab across runs and pre-download it with retries in both test jobs, reusing the SDK's URL/SHA256/cache logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_root_get_tokenizer_encodes_locally(and the legacy tokenizer tests) fail intermittently because the first-use vocab download from ModelScope times out on GitHub runners (e.g. run 44684550767, Python 3.10 leg:The read operation timed out).~/.cache/dashscope/tokenizersacross runs and pre-download the vocab with 5 retries and backoff before pytest, reusing the SDK's own URL/SHA256/cache logic (_resolve_vocab_path). Cache hits skip the network entirely.Test plan
tests/test_package_root.py::test_root_get_tokenizer_encodes_locally+tests/legacy_1x/unit/test_tokenizer.pypass locally (12 passed)