Repository navigation
Conversation
The vocab is fetched from ModelScope on first use, which is flaky from overseas runners. Pre-download it into the SHA256-verified local cache (with retries) in both the test and release workflows so tokenizer tests never hit the network during mvn test.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qwen.tiktokenvocab is downloaded from ModelScope on first use; tokenizer tests (TestQwenTokenizerVocabResolution,TestTikTokenTokenizer) can hit the network duringmvn test, which is flaky from overseas GitHub runners (same issue as the Python SDK'stest_root_get_tokenizer_encodes_locally).build-and-test.ymlandrelease.yml: fetch the vocab into~/.cache/dashscope/tokenizers/with curl retries (3 outer attempts × 3 curl retries) and SHA256 verification against the constant inQwenTokenizer.QwenTokenizer.resolveVocab()honors the verified cache before downloading, so tests run fully offline once the step succeeds; no production code or test changes needed.Test plan
b2b1b8df...) locallymvn test -Dtest='TestQwenTokenizerVocabResolution,TestTikTokenTokenizer': 11 tests, 0 failures