Repository navigation
rename metric label values for fetched-data limit rejections - #7517
SungJin1212 wants to merge 1 commit into
Conversation
ae41fd9 to
081be7e
Compare
friedrichg
left a comment
There was a problem hiding this comment.
This will break people's dashboards and alerts for no immediate gain.
Can you clarify why is this necessary?
| reasonResourceExhausted = "resource_exhausted" | ||
| reasonTimeRangeExceeded = "time_range_exceeded" | ||
| reasonResponseSizeExceeded = "response_size_exceeded" | ||
| reasonTooManySamples = "too_many_samples" |
There was a problem hiding this comment.
shouldn't this also be fetch_too_many_samples_exceeded?
There was a problem hiding this comment.
This might break existing dashboards and alerts. However, I realized that the existing values cannot clearly explain why the query is being rejected (these are label values of the reason).
I think the too_many_samples is clear enough to explain why the query is rejected.
The fetch_too_many_samples_exceeded is clearer, but I'd prefer to keep the changes to a minimum.
I won't block it. But I am not convinced yet either
| reasonFetchedSeriesExceeded = "fetched_series_exceeded" | ||
| reasonFetchedChunksExceeded = "fetched_chunks_exceeded" | ||
| reasonFetchedChunkBytesExceeded = "fetched_chunk_bytes_exceeded" | ||
| reasonFetchedDataBytesExceeded = "fetched_data_bytes_exceeded" |
There was a problem hiding this comment.
This change is incompatible. Do we have to introduce customer impacting changes here? Can we do it in a way without breaking
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
62e2ce5 to
b743d44
Compare
This PR updates the naming of
cortex_rejected_queries_totalmetric label values to make them more descriptive and consistent.series_fetched,chunks_fetched,chunk_bytes_fetched,data_bytes_fetched.fetched_series_exceeded,fetched_chunks_exceeded,fetched_chunk_bytes_exceeded,fetched_data_bytes_exceeded.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags