Skip to content

fix(deps): upgrade open to 11 and override papaparse to 5.7.1 to clear Snyk findings - #289

Merged
Harshi-Shah-CS merged 1 commit into
v2-devfrom
CL-0000_snyk-v2-dev-18-Nov-2026
Nov 18, 2026
Merged

Harshi-Shah-CS merged 1 commit into
v2-devfrom
CL-0000_snyk-v2-dev-18-Nov-2026

Conversation

@Harshi-Shah-CS

Copy link
Copy Markdown
Contributor

What

  • Upgrade open 8.4.2 → 11.0.4 (SNYK-JS-OPEN-22112123, High).
  • Override papaparse to ^5.7.1 under @contentstack/cli-utilities@2.0.2, the latest release (SNYK-JS-PAPAPARSE-22566253, High).
  • openInBrowser now loads the ESM-only open@11 through a Function-built import(), the same approach as V1's fix(deps): upgrade open to 11 and @oclif/core to 4.14 to clear Snyk findings #286. A static import compiles to require("open"), which crashes on Node 22.0–22.11, still allowed by engines (>=22.0.0).
  • The integration suites that mocked open now route src/core/browser through test/support/browser.ts, which runs the real openInBrowser against the mocked module, so no test opens a real browser.
  • The .talismanrc checksum for environments-create.test.ts is refreshed for its one-line change.

Not fixable here: adm-zip@0.6.1 and the open@8 that cli-utilities pulls in have no upgrade path, so they don't fail snyk test --fail-on=all.

Both findings currently fail the pre-commit Snyk hook on v2-dev. This PR unblocks CL-8788 (deployments:cancel 400 message), which follows once this merges.

Tests

  • npm test: 193 suites / 3818 tests pass. browser.ts is 100% covered, including a test that loads the real open@11.
  • npm run lint, tsc --noEmit and the build pass. The built dist/core/browser.js loads open@11 at runtime.
  • snyk test --all-projects --fail-on=all passes, and so does the pre-commit hook (lint-staged, Talisman, trufflehog, Snyk).

#claude_code#
🤖 Generated with Claude Code

…r Snyk findings

The pre-commit `snyk test --fail-on=all` started failing on v2-dev with
two new High findings:

- open@8.4.2 (SNYK-JS-OPEN-22112123), fixed in open@11.
- papaparse@5.5.4 via @contentstack/cli-utilities@2.0.2
  (SNYK-JS-PAPAPARSE-22566253), fixed in 5.7.1; cli-utilities 2.0.2 is
  the latest, so it is pinned with an override.

open@11 is ESM-only. A static import compiles to require("open"), which
crashes on Node 22.0-22.11 (still allowed by engines >=22.0.0), so
openInBrowser now loads it lazily through a Function-built import(),
matching V1's #286. It returns its promise so its tests can await the
swallowed failures, and a loader test covers the real dynamic import.

The integration suites that mocked 'open' now route src/core/browser
through test/support/browser.ts, which runs the real openInBrowser
against the mocked module, so no test launches a real browser. The
.talismanrc checksums for package.json and the three edited integration
suites are refreshed for these changes.

Left as is: adm-zip@0.6.1 and cli-utilities' own open@8 have no upgrade
path, so they do not fail --fail-on=all.

#claude_code#
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@Harshi-Shah-CS
Harshi-Shah-CS requested review from a team as code owners November 18, 2026 06:49
@snyk-io

snyk-io Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 2 25 ✅ Passed
🟡 Medium Severity 0 1 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 2
  • Medium without fixes: 1
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

@Harshi-Shah-CS
Harshi-Shah-CS merged commit 70f2415 into v2-dev Nov 18, 2026
7 checks passed
@Harshi-Shah-CS
Harshi-Shah-CS deleted the CL-0000_snyk-v2-dev-18-Nov-2026 branch November 18, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants