Repository navigation
Conversation
|
/coder-agents-review |
|
Chat: Review posted | View chat Review history
deep-review v0.13.0 | Round 1 | Last posted: Round 1, 4 findings (2 P3, 2 P4), COMMENT. Review Finding inventoryFinding inventory, PR #599Findings
Contested and acknowledgedNone. Round logRound 1Full panel (round 1). Netero: no findings, 1 Note. Law not run (+45 effective). Panel: ging-go, takumi, killua, ryosuke (Go specialists), pariston, mafuuu (core), bisky (test code), gon, leorio (once-per-PR floor), komugi (flake fix), kite (wildcard). Size 11 exceeds the focused target of 6-8 because 4 specialists, Bisky, and the Gon/Leorio floor are required. 2 P3, 3 P4 open; 6 dropped; 7 out of scope. Orchestrator reproduced CRF-1 on Docker 27.5.1 ( About deep-reviewCRF = Coder Review Finding (P0-P4, Nit, Note)
|
TestAutobahn gave the wstest container 5s to accept a handshake after docker run. Since the daily jobs moved to ubuntu-26.04 (Docker 29.4.2), the first container start on a fresh runner takes 2.8s to 12s, then wstest needs about 1s more to listen. On 24.04 (Docker 28.0.4) the first start took under 0.5s. The test failed in 13 of 27 daily test jobs since 2026-10-30. waitWS now allows a minute, sleeps 100ms between dials instead of dialing in a busy loop, and returns the last dial error.
Killing the docker run client leaves the container running, so each TestAutobahn run left a wstest container behind. closeFn now removes the container by name. wstestServer now returns once the server accepts handshakes, and stops waiting when docker run exits, so a server that fails to start fails the test right away. That lets the wait allow 5 minutes for a slow start.
The image is pulled before docker run, so the wait covers only the container start and wstest's startup, which took at most 13.5s on the runners measured. 2 minutes is enough for that. docker run exiting now cancels the wait's context with the exit error as its cause, so waitWS needs no separate channel.
docker rm --force keeps the image's anonymous /config and /reports volumes, which --rm would remove, so every run left two volumes. closeFn now passes --volumes. The container name came from the port, and unusedListenAddr releases the port before docker binds it, so another run could get the same name, and a failing run's closeFn would remove the other run's container. The name is now random. The 2 minute limit moves from waitWS to wstestServer, next to the measurement that explains it, and its cause names the limit in the error instead of a second "context deadline exceeded".
1f8a5d0 to
6742435
Compare
TestAutobahngave the wstest container 5s afterdocker runto accept a WebSocket handshake. On GitHub's ubuntu-26.04 runners that is often not enough, and the dailytestjobs fail withautobahn_test.go:72: context deadline exceeded(#598). Since the daily jobs moved to 26.04 on 2026-10-30, 13 of 27 failed this way.The image is already pulled when the wait starts. The time goes to the first container start after
docker pull: on 26.04 (Docker 29.4.2 with the containerd image store), that start took about 2.8s on AMD EPYC 7763 VMs and 2.9s to 7.3s on EPYC 9V45, EPYC 9V74 and Xeon 8573C VMs. wstest starts listening about 1.1s later. Under the fullci/test.shload, the server took 2.4s to 13.5s to accept a handshake. On 24.04 (Docker 28.0.4), the same start took under 0.5s on every VM type. The daily failures follow the VM type: 0 of 11 jobs on EPYC 7763 and 0 of 1 on Xeon 8370C failed, and 13 of 15 on EPYC 9V45, EPYC 9V74 and Xeon 8573C.wstestServernow returns once the server accepts a handshake. It dials every 100ms instead of in a busy loop, fails as soon asdocker runexits, and gives up after 2 minutes.Killing the
docker runclient does not stop the container, so each run left a wstest container running.closeFnnow removes the container and its anonymous volumes. The container gets a random name, because another run can get the same port.Refs #598
Verification
AUTOBAHN=1 make teston ubuntu-26.04 with earlier versions of this branch: 43599366425 (5 minute limit, same container removal), 8 of 8 passed (5 on the slower VM types), with no container left afterwards. 43595298461 (1 minute limit), 6 of 6 passed. Master's test in the same run passed 5 of 6 and failed once with the 5s error.AUTOBAHN=fastpasses and leaves no container or volume. With an invalid wstest mode, the test fails after 1.8s withwstest exited: exit status 1. With the limit set to 3s and an unused port, it fails withtimed out after 3sand removes the container.make lintpassed.Decision log
docker runexit, which ends the wait right away.