Repository navigation
SDK-8048: run accessibility on Cypress 16.1.0-16.2.0 with forceHttp1 (stacked on #1206) - #1222
Open
AakashHotchandani wants to merge 2 commits into
Open
AakashHotchandani wants to merge 2 commits into
AakashHotchandani wants to merge 2 commits into
Conversation
Cypress 16.2.0's default network mode never starts the a11y extension's service worker (cypress-io/cypress#35127, fixed in 16.2.1), so every scan waits out the 25s timeout and the build still passes. forceHttp1 avoids it: on the same preprod Ventura pool, the scan step took 25.6s without it and 4.2s with it (15.21.1: 5.0s). - Accessibility builds on Cypress 16 get forceHttp1=true added to run_settings.config. Other config keys are kept, and a forceHttp1 the user already set (true or false) is left alone. - MAX_CYPRESS_MAJOR_FOR_ACCESSIBILITY 15 -> 16, so 16 is allowed and 17+ is still refused. - Builds with no cypress_version still ask for 15 (DEFAULT_CYPRESS_MAJOR_FOR_ACCESSIBILITY), matching Rails' default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
….0 to 16.2.0) The extension service-worker bug is a regression from cypress-io/cypress#34762 (16.1.0), reported as #35127 and fixed by #34958 in 16.2.1. Builds asking for 16.2.1+ or 16.0.x no longer get forceHttp1. "16" and "16.latest" still do while 16.2.0 is the only Cypress 16 Rails offers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1206 (
APS-22894-cypress-16-expose). Lets accessibility run on Cypress 16.2.0 instead of refusing it, by turning onforceHttp1for the Cypress versions that have the bug (16.1.0 to 16.2.0).Why
From Cypress 16.1.0 to 16.2.0 the a11y extension's service worker never starts. It's a regression from cypress-io/cypress#34762 (16.1.0), reported as #35127 on 16.2.0, and fixed by #34958 in 16.2.1 (released 28 Oct). Every scan waits out the 25s timeout and the build still passes, so customers lose a11y results without any error.
forceHttp1avoids the bug.Same-day A/B on preprod (Ventura, Chrome 148, same account and CLI build), 20 Nov:
forceHttp1388951c4d09f0ba9352f0b15cd7ca3fc352f0b15had noconfiginbrowserstack.json. The CLI added forceHttp1 by itself (that run used the first commit, faff373, whose log line said "Cypress 16"; 0cafced narrows it to 16.1.0-16.2.0 and the message now says so).What changes
cypress_versionis 16.1.0, 16.1.1 or 16.2.0 (range[16.1.0, 16.2.1)inACCESSIBILITY_FORCE_HTTP1_CYPRESS_RANGE),forceHttp1=trueis appended torun_settings.config. Other config keys are kept. If the user already setforceHttp1(true or false), it's left alone.16and16.latest: these name no minor version and Rails resolves them. They getforceHttp1while 16.2.0 is the only Cypress 16 Rails offers. Once Rails offers 16.2.1+, that branch should be removed.forceHttp1.MAX_CYPRESS_MAJOR_FOR_ACCESSIBILITY15 → 16. Cypress 16 is allowed and 17+ is still refused.DEFAULT_CYPRESS_MAJOR_FOR_ACCESSIBILITY), matching Rails' default. This PR doesn't move anyone to 16 who didn't ask for it.forceHttp1is added.Not covered
cypress_version: "latest": the CLI can't tell which major Rails will resolve it to, soforceHttp1isn't added. If Rails resolveslatestto 16 for a11y builds, this needs a backend/terminal fallback. Terminals already setforceHttp1for Cypress 16 with network logs or Local (terminalDeploy #8868), and extending that condition to accessibility would cover it.forceHttp1.forceHttp1sends traffic through Cypress's HTTP/1.1 proxy (no HTTP/2, somecy.interceptdifferences) and Cypress prints a deprecation warning. It only applies to the affected versions, so customers on 16.2.1+ get the normal network mode.Tests
test/unit/bin/helpers/capabilityHelper.js: forceHttp1 added for16/16.latest/16.1.0/16.1.1/16.2.0; other keys kept; a user-setforceHttp1=falserespected; not added for16.0.0,16.2.1,16.3.0, 15, no version (pinned to 15), a11y off, orlatest. Refusal now covers 17+; 16 is accepted.capabilityHelper.js: 99 passing. The 5utils.jsfailures are the same on the base branch without this change.352f0b15(above), installed from a test drop branch,SDK-8048-cypress16-preprod-drop.Ticket: SDK-8048 · Release: APS-22894
🤖 Generated with Claude Code