Skip to content

SDK-8048: run accessibility on Cypress 16.1.0-16.2.0 with forceHttp1 (stacked on #1206) - #1222

Open
AakashHotchandani wants to merge 2 commits into
APS-22894-cypress-16-exposefrom
SDK-8048-a11y-cypress16-forcehttp1
Open

AakashHotchandani wants to merge 2 commits into
APS-22894-cypress-16-exposefrom
SDK-8048-a11y-cypress16-forcehttp1

Conversation

@AakashHotchandani

@AakashHotchandani AakashHotchandani commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked on #1206 (APS-22894-cypress-16-expose). Lets accessibility run on Cypress 16.2.0 instead of refusing it, by turning on forceHttp1 for the Cypress versions that have the bug (16.1.0 to 16.2.0).

Why

From Cypress 16.1.0 to 16.2.0 the a11y extension's service worker never starts. It's a regression from cypress-io/cypress#34762 (16.1.0), reported as #35127 on 16.2.0, and fixed by #34958 in 16.2.1 (released 28 Oct). Every scan waits out the 25s timeout and the build still passes, so customers lose a11y results without any error. forceHttp1 avoids the bug.

Same-day A/B on preprod (Ventura, Chrome 148, same account and CLI build), 20 Nov:

Build Cypress forceHttp1 extension marker click scan step
388951c4 16.2.0 no 55.7s 25.58s (scan timeout)
d09f0ba9 16.2.0 yes, set by hand 8.36s 4.21s
352f0b15 16.2.0 yes, added by this PR 8.23s 5.11s
cd7ca3fc 15.21.1 n/a 8.84s 5.03s

352f0b15 had no config in browserstack.json. The CLI added forceHttp1 by itself (that run used the first commit, faff373, whose log line said "Cypress 16"; 0cafced narrows it to 16.1.0-16.2.0 and the message now says so).

What changes

  • Accessibility on affected Cypress versions: when accessibility is on and cypress_version is 16.1.0, 16.1.1 or 16.2.0 (range [16.1.0, 16.2.1) in ACCESSIBILITY_FORCE_HTTP1_CYPRESS_RANGE), forceHttp1=true is appended to run_settings.config. Other config keys are kept. If the user already set forceHttp1 (true or false), it's left alone.
  • 16 and 16.latest: these name no minor version and Rails resolves them. They get forceHttp1 while 16.2.0 is the only Cypress 16 Rails offers. Once Rails offers 16.2.1+, that branch should be removed.
  • 16.0.x and 16.2.1+: no forceHttp1.
  • Limit: MAX_CYPRESS_MAJOR_FOR_ACCESSIBILITY 15 → 16. Cypress 16 is allowed and 17+ is still refused.
  • No version given: accessibility builds still ask for 15 (new DEFAULT_CYPRESS_MAJOR_FOR_ACCESSIBILITY), matching Rails' default. This PR doesn't move anyone to 16 who didn't ask for it.
  • Messages: the refusal message says "up to version 16", and there's a new info message when forceHttp1 is added.

Not covered

  • cypress_version: "latest": the CLI can't tell which major Rails will resolve it to, so forceHttp1 isn't added. If Rails resolves latest to 16 for a11y builds, this needs a backend/terminal fallback. Terminals already set forceHttp1 for Cypress 16 with network logs or Local (terminalDeploy #8868), and extending that condition to accessibility would cover it.
  • CLIs without this change get no forceHttp1.
  • Trade-off: forceHttp1 sends traffic through Cypress's HTTP/1.1 proxy (no HTTP/2, some cy.intercept differences) and Cypress prints a deprecation warning. It only applies to the affected versions, so customers on 16.2.1+ get the normal network mode.

Tests

  • test/unit/bin/helpers/capabilityHelper.js: forceHttp1 added for 16 / 16.latest / 16.1.0 / 16.1.1 / 16.2.0; other keys kept; a user-set forceHttp1=false respected; not added for 16.0.0, 16.2.1, 16.3.0, 15, no version (pinned to 15), a11y off, or latest. Refusal now covers 17+; 16 is accepted.
  • capabilityHelper.js: 99 passing. The 5 utils.js failures are the same on the base branch without this change.
  • E2E: preprod build 352f0b15 (above), installed from a test drop branch, SDK-8048-cypress16-preprod-drop.

Ticket: SDK-8048 · Release: APS-22894

🤖 Generated with Claude Code

Cypress 16.2.0's default network mode never starts the a11y extension's service worker
(cypress-io/cypress#35127, fixed in 16.2.1), so every scan waits out the 25s timeout and the
build still passes. forceHttp1 avoids it: on the same preprod Ventura pool, the scan step took
25.6s without it and 4.2s with it (15.21.1: 5.0s).

- Accessibility builds on Cypress 16 get forceHttp1=true added to run_settings.config. Other
  config keys are kept, and a forceHttp1 the user already set (true or false) is left alone.
- MAX_CYPRESS_MAJOR_FOR_ACCESSIBILITY 15 -> 16, so 16 is allowed and 17+ is still refused.
- Builds with no cypress_version still ask for 15 (DEFAULT_CYPRESS_MAJOR_FOR_ACCESSIBILITY),
  matching Rails' default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Default branch
  • Repository: browserstack/browserstack-cypress-cli
  • Branch: master
  • File: .coderabbit.yaml
  • Commit: aedf9e9
  • Layers: Repository YAML (base), Central YAML (inherited), Organization UI (inherited), Workspace UI (inherited); Enforced overrides: Organization
  • Review profile: ASSERTIVE
  • Plan: Enterprise
  • Run ID: e88ddb57-8383-4240-9830-d98b4b791de0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

….0 to 16.2.0)

The extension service-worker bug is a regression from cypress-io/cypress#34762 (16.1.0),
reported as #35127 and fixed by #34958 in 16.2.1. Builds asking for 16.2.1+ or 16.0.x no
longer get forceHttp1. "16" and "16.latest" still do while 16.2.0 is the only Cypress 16
Rails offers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AakashHotchandani AakashHotchandani changed the title SDK-8048: run accessibility on Cypress 16 with forceHttp1 (stacked on #1206) SDK-8048: run accessibility on Cypress 16.1.0-16.2.0 with forceHttp1 (stacked on #1206) Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant