Repository navigation
Fix negative integer row indexing in FSArray - #199
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Negative integer row lookups such as
array[-1]always raiseIndexError: the index normalization subtracts the negative offset from the row count. Add the offset instead, so these lookups return the stored formatted row.Regression coverage checks every valid positive and negative index, styled-row identity after replacement, slices, and out-of-range lookups for empty, one-row and multi-row arrays. The final tests fail on unchanged upstream and pass with the fix.
Validation: full suite including doctests and terminal tests passes under a Linux PTY on CPython 3.10.22, 3.12.3 and 3.14.10 (111 passed, one skipped, four expected failures each); source/wheel builds pass. Codespell and test formatting pass. Full Black checks retain the same three existing file failures, and mypy retains the same 28
window.pyerrors on clean upstream and this branch. No native macOS/Windows or interactive bpython test was run.