Skip to content

Add tabIndex reflection and button defaults - #99

Closed
cowboyd wants to merge 1 commit into
dom-inertfrom
dom-tabindex
Closed

cowboyd wants to merge 1 commit into
dom-inertfrom
dom-tabindex

Conversation

@cowboyd

@cowboyd cowboyd commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Add HTMLElement.tabIndex reflection and create HTMLButtonElement instances for button elements. Ordinary HTML elements default to -1, while buttons default to 0.

This is a prerequisite for the focus work in #78; focus eligibility checks remain separate. No separate issue is needed for this incremental addition.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

@pkg-pr-new

pkg-pr-new Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/bombshell-dev/ui/@clack/ui@99

commit: 99d3573

@cowboyd
cowboyd added this pull request to stack #98 November 18, 2026 17:01
Comment thread packages/ui/src/dom.ts

export class XMLDocument extends Document {}

function Focusable<Ctor extends new (...args: any[]) => HTMLElement>(ElementType: Ctor): Ctor {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the mixin approach here honestly!

@cowboyd
cowboyd removed this pull request from stack #98 November 19, 2026 17:17
@cowboyd
cowboyd added this pull request to stack #106 November 19, 2026 17:18
@cowboyd

cowboyd commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

no stacks on stacks

@cowboyd cowboyd closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants