Skip to content

Add Document.getElementById for focus test fixtures - #93

Closed
cowboyd wants to merge 1 commit into
mainfrom
dom-id-lookup
Closed

cowboyd wants to merge 1 commit into
mainfrom
dom-id-lookup

Conversation

@cowboyd

@cowboyd cowboyd commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by #70. Its ID lookup implementation and WPT coverage are consolidated into the shared DOM foundation used by both styling and focus. The focus stack now starts at #75 on top of #70.

What does this PR do?

Add Document.getElementById() so the upstream focus and inert WPT fixtures can locate their elements.

This builds on the native WPT base in #87 as a prerequisite before #75, keeping the focus PR focused on focus behavior.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

@cowboyd
cowboyd added this pull request to stack #94 November 17, 2026 22:49
@pkg-pr-new

pkg-pr-new Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/bombshell-dev/ui/@clack/ui@93

commit: 1346f87

@cowboyd
cowboyd force-pushed the dom-id-lookup branch 2 times, most recently from 5fc9851 to 4789719 Compare November 18, 2026 02:23
@cowboyd
cowboyd removed this pull request from stack #94 November 18, 2026 02:24
@cowboyd
cowboyd changed the base branch from dom-default-view to wpt-window-named-access November 18, 2026 02:24
@cowboyd
cowboyd added this pull request to stack #96 November 18, 2026 02:24
@cowboyd
cowboyd removed this pull request from stack #96 November 18, 2026 02:27
@cowboyd
cowboyd changed the base branch from wpt-window-named-access to dom-default-view November 18, 2026 02:27
@cowboyd
cowboyd added this pull request to stack #98 November 18, 2026 02:27
@cowboyd
cowboyd force-pushed the dom-default-view branch 2 times, most recently from db70c94 to f7077a8 Compare November 18, 2026 02:44
@cowboyd
cowboyd force-pushed the dom-default-view branch 2 times, most recently from 3656a37 to 8697662 Compare November 18, 2026 21:48
Base automatically changed from dom-default-view to main November 18, 2026 21:50

@natemoo-re natemoo-re left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cowboyd
cowboyd removed this pull request from stack #98 November 19, 2026 17:17
@cowboyd cowboyd closed this Nov 19, 2026
@cowboyd
cowboyd deleted the dom-id-lookup branch November 20, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants