Repository navigation
Conversation
commit: |
natemoo-re
reviewed
Nov 15, 2026
natemoo-re
left a comment
Member
There was a problem hiding this comment.
just some suggestions! shaping up nicely
| if (!this.isConnected) { | ||
| return; | ||
| } | ||
| this.ownerDocument._setActiveElement(this); |
Member
There was a problem hiding this comment.
interesting! do you know how the browser handles privileged methods like this?maybe this could be a local function that stores state per document in a WeakMap or something? there's probably a nicer way than that, just the first thing that came to mind.
Contributor
Author
There was a problem hiding this comment.
Yeah, we could do it that way. It would certainly make it so that don't have a "rogue" public method that someone could invoke on their own.
cowboyd
marked this pull request as draft
November 17, 2026 17:46
cowboyd
force-pushed
the
dom-focus
branch
2 times, most recently
from
November 17, 2026 21:43
2741801 to
97a7748
Compare
natemoo-re
approved these changes
Nov 19, 2026
Contributor
Author
|
no stacks on stacks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement explicitly focusing and blurring and the according event dispatch. This is a prerequisite for events moving focus around.
The existing focus cases now run directly from upstream WPT on the native WPT base (#87). Relevant specs: HTML’s focusing steps and DOM’s event dispatch.
Type of change
Checklist
AI-generated code disclosure