Skip to content

Add HTMLElement.dataset - #101

Closed
cowboyd wants to merge 1 commit into
dom-query-selector-allfrom
dom-dataset
Closed

cowboyd wants to merge 1 commit into
dom-query-selector-allfrom
dom-dataset

Conversation

@cowboyd

@cowboyd cowboyd commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Expose HTMLElement.dataset as a cached DOMStringMap synchronized with data-* attributes. Property reads, writes, deletion, and enumeration use the element's current attributes and dataset name conversion.

This lets the focus fixtures in the work following #78 read their data attributes. No separate issue is needed for this incremental prerequisite.

SVG and MathML dataset support remains deferred until their element interfaces exist. Explicit configurable: false property definitions are rejected because the Proxy exposes virtual properties.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

@pkg-pr-new

pkg-pr-new Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/bombshell-dev/ui/@clack/ui@101

commit: 2304ce2

@cowboyd
cowboyd added this pull request to stack #98 November 18, 2026 17:01
@cowboyd
cowboyd removed this pull request from stack #98 November 19, 2026 17:17
@cowboyd
cowboyd added this pull request to stack #106 November 19, 2026 17:18
@cowboyd

cowboyd commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

no stacks on stacks

@cowboyd cowboyd closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants