Skip to content

Open pin-comment repair PRs as the org PR bot - #231

Merged
jeremy merged 1 commit into
masterfrom
pr-bot-sync-pin
Nov 22, 2026
Merged

jeremy merged 1 commit into
masterfrom
pr-bot-sync-pin

Conversation

@jeremy

@jeremy jeremy commented Nov 22, 2026 •

Copy link
Copy Markdown
Member

Moves the pin-comment sync's reusable workflow to basecamp/.github@7f89ca5 (.github#23). That version opens the repair PR as the org's 37s-pr-bot App, not with GITHUB_TOKEN, so the sync keeps working after the org turns off "Allow GitHub Actions to create and approve pull requests".

  • The secrets-inherit suppression's reason now names PR_BOT_PRIVATE_KEY, which the called workflow reads from this version on. The org shares that secret with this repo, and the App is installed here.
  • The job's permissions are unchanged. pull-requests: write is still needed, because GITHUB_TOKEN arms auto-merge on the repair PR.
  • Checked locally: actionlint passes, and zizmor (with a token, so online audits ran) reports no findings.

Summary by cubic

Updates the pin-comment sync to open repair PRs as the org's 37s-pr-bot App, so the sync keeps working after the org turns off "Allow GitHub Actions to create and approve pull requests".

  • Bumps the basecamp/.github workflow reference to a version that reads PR_BOT_PRIVATE_KEY, which the org shares with this repo.
  • pull-requests: write stays on the job because GITHUB_TOKEN still arms auto-merge on the repair PR.

Written for commit 0656d42. Summary will update on new commits.

View guided diff Turn on auto-fix

Copilot AI balanced review requested due to automatic review settings November 22, 2026 06:03
@github-actions

Copy link
Copy Markdown

Sensitive Change Detection (shadow mode)

This PR modifies control-plane files:

  • .github/workflows/dependabot-sync-actions-comments.yml

Shadow mode — this check is informational only. When activated, changes to these paths will require approval from a maintainer.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues are identified for the shared workflow pin and bot-secret documentation changes.

No open issues 🎉

What changed in this PR

Updates the shared pin-comment sync workflow so repair PRs use the organization’s 37s-pr-bot App and continue working when GitHub Actions is prohibited from creating PRs.

Changes:

  • Pins the reusable workflow to commit 7f89ca5c8847c428244320be371f07bf96b6d226.
  • Updates the security-suppression comment to document inherited PR_BOT_PRIVATE_KEY access.
  • Keeps job permissions unchanged, including pull-requests: write for enabling auto-merge.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File Description
.github/​workflows/​dependabot-sync-actions-comments.yml Updates the shared workflow pin and documents the additional bot secret.

Review effort: Balanced

@jeremy
jeremy merged commit 8ec7b9e into master Nov 22, 2026
17 checks passed
@jeremy
jeremy deleted the pr-bot-sync-pin branch November 22, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants