Repository navigation
Open pin-comment repair PRs as the org PR bot - #231
Merged
Merged
Conversation
Sensitive Change Detection (shadow mode)This PR modifies control-plane files:
|
Contributor
There was a problem hiding this comment.
🟢 Approved
No active review issues are identified for the shared workflow pin and bot-secret documentation changes.
No open issues 🎉
What changed in this PR
Updates the shared pin-comment sync workflow so repair PRs use the organization’s 37s-pr-bot App and continue working when GitHub Actions is prohibited from creating PRs.
Changes:
- Pins the reusable workflow to commit
7f89ca5c8847c428244320be371f07bf96b6d226. - Updates the security-suppression comment to document inherited
PR_BOT_PRIVATE_KEYaccess. - Keeps job permissions unchanged, including
pull-requests: writefor enabling auto-merge.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
.github/workflows/dependabot-sync-actions-comments.yml |
Updates the shared workflow pin and documents the additional bot secret. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the pin-comment sync's reusable workflow to basecamp/.github@7f89ca5 (.github#23). That version opens the repair PR as the org's
37s-pr-botApp, not withGITHUB_TOKEN, so the sync keeps working after the org turns off "Allow GitHub Actions to create and approve pull requests".secrets-inheritsuppression's reason now namesPR_BOT_PRIVATE_KEY, which the called workflow reads from this version on. The org shares that secret with this repo, and the App is installed here.pull-requests: writeis still needed, becauseGITHUB_TOKENarms auto-merge on the repair PR.Summary by cubic
Updates the pin-comment sync to open repair PRs as the org's
37s-pr-botApp, so the sync keeps working after the org turns off "Allow GitHub Actions to create and approve pull requests".basecamp/.githubworkflow reference to a version that readsPR_BOT_PRIVATE_KEY, which the org shares with this repo.pull-requests: writestays on the job becauseGITHUB_TOKENstill arms auto-merge on the repair PR.Written for commit 0656d42. Summary will update on new commits.