Repository navigation
Fix configurable content type charset handling - #1730
Open
Thapasvini wants to merge 1 commit into
Open
Thapasvini wants to merge 1 commit into
Thapasvini wants to merge 1 commit into
Conversation
Thapasvini
force-pushed
the
fix/content-type-charset
branch
from
November 18, 2026 04:28
326475b to
1992f21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the request reader automatically appends the default charset (ISO-8859-1) to the Content-Type header when the incoming request doesn't specify one.
In some cases, applications need the original Content-Type header to remain unchanged, especially when validating request signatures or HMACs where the exact header value matters.
This change adds a new configuration option, appendDefaultContentCharset, to ContainerConfig.
Defaults to true to preserve the existing behavior.
Can be set to false to prevent the default charset from being appended and preserve the original Content-Type header.
Added a test to verify that the original Content-Type header is preserved when the option is disabled.