Repository navigation
MINOR: [1.17.x] Upgrade Thrift to 0.25.0 - #3974
Open
adoroszlai wants to merge 2 commits into
Open
adoroszlai wants to merge 2 commits into
adoroszlai wants to merge 2 commits into
Conversation
* apacheGH-3572 Bump thrift to 0.23 Added instructions in docs as to where to find the gpg/sha signatures and a link to the thrift team KEYS file. * Thrift 0.23 now checks limits (good!) on read write and depth But it means: if you don't supply a TTransport to TProtocol ctor you hit an NPE during IO whenever those limits are validated. Add a StubTTransport which no-ops the read range check and declares there's no limit on depth checking. * Spotless * review feedback (cherry picked from commit fb5d512)
Backport the relevant parts of apache#3855 directly from 0.23.0 to 0.25.0. Update the runtime and compiler together, align CI and build instructions, and implement the transport reset method required by Thrift 0.25.0. (cherry picked from commit b97860d) Co-authored-by: Fokko Driesprong <fokko@apache.org> Co-authored-by: Codex <codex@openai.com> (cherry picked from commit 01bb09c)
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Backport Thrift version bump to 1.17.x for security.
What changes are included in this PR?
Are these changes tested?
https://github.com/adoroszlai/parquet-java/actions/runs/44486915466
https://github.com/adoroszlai/parquet-java/actions/runs/44486915416
Are there any user-facing changes?
From #3891: