Repository navigation
Core: Accept Arrow PyCapsule exporters in append and overwrite - #4460
Open
Anurag-S1ngh wants to merge 2 commits into
Open
Anurag-S1ngh wants to merge 2 commits into
Anurag-S1ngh wants to merge 2 commits into
Conversation
Writes rejected anything that was not a pyarrow Table or RecordBatchReader, which forced users of Polars, arro3, and other Arrow implementations to import pyarrow themselves and convert first. Accept objects that implement the Arrow PyCapsule stream interface and import them as a pyarrow Table. RecordBatchReader keeps the streaming path, and the error message names the accepted types.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Writes rejected anything that was not a
pyarrow.Tableorpyarrow.RecordBatchReader, which forced users of Polars, arro3, and other Arrow implementations to import PyArrow themselves and convert first.Accept objects that implement the Arrow PyCapsule stream interface (
__arrow_c_stream__) inappendandoverwrite, and import them as a PyArrow table.RecordBatchReaderkeeps the existing streaming path. The error message now names the accepted types.Are these changes tested?
Yes. A wrapper implementing only
__arrow_c_stream__is written through bothappendandoverwrite, and an object without the interface is rejected.tests/tablepasses.Are there any user-facing changes?
Yes.
appendandoverwriteaccept any object implementing the Arrow PyCapsule stream interface.