Skip to content

feat(inspect): add partitions metadata table - #1122

Draft
manuzhang wants to merge 1 commit into
apache:mainfrom
manuzhang:codex/partitions-metadata-table-20261115
Draft

manuzhang wants to merge 1 commit into
apache:mainfrom
manuzhang:codex/partitions-metadata-table-20261115

Conversation

@manuzhang

@manuzhang manuzhang commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Depends on #1120 (scan contracts/tasks), #1133 (lazy Arrow batching), #1134 (partition values), and #1135 (live-file iteration). Apply those prerequisites when building this draft; merge them first, then rebase this branch onto main. This table is independent of FilesTable and ManifestsTable.

Add PartitionsTable through Table::Inspect(MetadataTableKind::kPartitions). Aggregate live data/delete files by projected partition values and expose record/file counts, data-file sizes, spec IDs, and last-update metadata.

Scans retain metadata/projection/FileIO and support whole-column projection and configurable batches. Aggregation unifies evolved partition specs, canonicalizes NaNs, and preserves signed zeros. Mutex-protected schema caches retain ownership safely during concurrent builder creation. Manifest reads select only fields required for aggregation.

The shared scan test fixture accompanies its real consumers; identical copies in the other table drafts disappear on rebase once the fixture lands.

Validation with the helper prerequisites applied: all 95 metadata tests and C++20 compatibility passed. Feature-specific code and factory were compiled and linked against the separately built helper foundation. Pre-commit and clang-tidy 22.1.8 passed.

Copilot AI balanced review requested due to automatic review settings November 14, 2026 16:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

Extract a focused piece from the metadata table implementation with its tests.

Co-authored-by: Codex <codex@openai.com>
@manuzhang
manuzhang force-pushed the codex/partitions-metadata-table-20261115 branch from 44c237a to 01a99ed Compare November 15, 2026 15:26
Copilot AI balanced review requested due to automatic review settings November 15, 2026 15:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

wgtmac pushed a commit that referenced this pull request Nov 20, 2026
## Purpose

Regular data-table scans already support snapshot selection through `UseSnapshot()`, `UseRef()`, and `AsOfTime()`. `MetadataScanBuilder` also already exposes these selectors, but its implemented metadata tables (`snapshots`, `history`, and `refs`) use in-memory static tasks and reject time-travel selection.

This PR adds a generic snapshot-task execution path for the upcoming FilesTable (#876), ManifestsTable (#1121), and PartitionsTable (#1122) implementations. Those tables need to read metadata rows for a selected snapshot. The table implementations follow in their own PRs.

A source-table refresh after `NewScan()` must not change a builder's captured inputs. Built scans, tasks, and row streams retain their inputs for their own lifetimes. This PR supplies that ownership contract and builds directly on main.

## Changes and rationale

- **Capture consistent inputs.** The builder captures metadata and FileIO, then derives the schema through `SchemaForScan(captured_metadata)`. FileIO is held separately from `MetadataScanContext` and passed to the table's `MakeScan()` hook, so snapshot tasks retain the captured IO even after a source refresh.
- **Share snapshot-task execution.** Define `SnapshotMetadataTask` alongside `StaticMetadataTask` in `metadata_scan_task.h/.cc`. Its factory validates the context, FileIO, and row-reader callback. `MetadataScanTaskReader` opens it through that callback, allowing table-specific readers without a dispatch branch for every table.
- **Validate before reading.** Centralize required metadata/schema checks in `MetadataScanContext::Validate()`, check whole-column projections, and resolve snapshot IDs, references, or timestamps against captured metadata. Reference lookup reuses `SnapshotUtil::LatestSnapshot()` after strict reference validation. Empty main selections return `nullptr`; dangling snapshot IDs remain errors. Main-branch detection is shared through `SnapshotUtil::IsMainBranch()`.
- **Retain execution inputs.** Tasks can be reopened with independent streams and configurable batch sizes. The builder, task, and active stream each retain the FileIO they need; static in-memory scans do not require FileIO.

## Public API and ABI changes

The public virtual getter changes its return type:

```diff
- virtual const std::shared_ptr<Schema>& schema() const = 0;
+ virtual std::shared_ptr<Schema> schema() const = 0;
```

The member function remains `const`. Returning the pointer by value lets implementations copy it under their schema-cache lock, giving callers ownership that remains valid when the cache is replaced. This copies the `shared_ptr`, not the `Schema`.

Derived metadata tables must also update their protected `MakeScan()` override to accept the builder-captured `std::shared_ptr<FileIO>` as its second argument. The PR adds the protected `SchemaForScan()` hook, `SnapshotMetadataTask`, and `TaskKind::kSnapshot`. Existing binary consumers must be rebuilt.

## Execution scope

The initial snapshot scan plans one task using an in-process row-reader callback. Splitting work into multiple tasks and providing serializable task descriptions are follow-up work for parallel and distributed execution.

## Validation

- All 62 metadata tests passed, including missing-input checks, repeated task opening, static scanning without FileIO, and the new FileIO-capture regression across source refresh and builder/scan/task destruction.
- C++20 public-header compatibility passed.
- Required pre-commit and changed-code clang-tidy 22.1.8 passed.

Local validation covers the standalone static Debug scan implementation and tests, rebuilt against this revision with unchanged cached static dependencies. Dependent table PRs must pass captured FileIO separately when adapting their `MakeScan()` overrides.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants