Skip to content

ignore Domain attributes ending with '.' in RFC6265CookieSpec - #957

Open
Hsnmohd wants to merge 1 commit into
apache:masterfrom
Hsnmohd:cookie-domain-trailing-dot
Open

Hsnmohd wants to merge 1 commit into
apache:masterfrom
Hsnmohd:cookie-domain-trailing-dot

Conversation

@Hsnmohd

@Hsnmohd Hsnmohd commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

RFC6265CookieSpec.parseCookie still recorded a Domain attribute ending with '.' that BasicDomainHandler.parse ignores, so a host-only cookie from example.com set with Domain=example.com. matched every subdomain such as evil.example.com; drop it the same way 06ca922 drops empty Domain attributes.

@ok2c

ok2c commented Nov 21, 2026

Copy link
Copy Markdown
Member

@Hsnmohd Should not the cookie rather be rejected as invalid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants