Repository navigation
fix(config-ui): base the UI image on the maintained nginx 1.31.9 - #9424
Open
alexinthesky wants to merge 1 commit into
Open
alexinthesky wants to merge 1 commit into
alexinthesky wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
config-ui/Dockerfilebuilds onnginxinc/nginx-unprivileged:1.31.7. That tag has two problems:1.25or1.31.7will never move again, so no rebuild of this image can pick up a newer nginx.The maintained Docker Official Image,
nginx/nginx-unprivileged, already publishes 1.31.9.Change
One line. The rest of the file already does what the new base needs:
No other edit is needed, and I checked why:
nginx/nginx-unprivileged:1.31.9USER 0for the root stepsUSER 0still worksUSER 101at the endnginxuser is also uid 101apache2-utils(htpasswd, used bynginx.shwhen basic auth is on)apt-get install -y apache2-utils iproute2iproute2(ip -4 addr, used bynginx.shto pick thelistendirective)chgrp -R 0 … && chmod -R g=u …for arbitrary-uid support/etc/nginxisnginx:rootwith group writeRUN rm /etc/nginx/conf.d/default.confUSER 0, and/etc/nginxis group-writable regardlessTesting
I rebuilt the runtime half of this Dockerfile (skipping the Node build) on
nginx/nginx-unprivileged:1.31.9forlinux/arm64, using the realnginx.shanddefault.conf.tplfrom the releasedconfig-uiimage, and with the exact step order of the current file:There is no behavioural change beyond the nginx version: same assets, same config template, same entrypoint, same uid.
Notes
1.31.9(mainline) rather than1.30.7(stable) keeps this a patch bump from the current 1.31.7.