Repository navigation
Add backup file extraction feature - #13935
JoaoJandre wants to merge 8 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #13935 +/- ##
=============================================
- Coverage 20.77% 3.85% -16.92%
=============================================
Files 6053 495 -5558
Lines 548222 42979 -505243
Branches 73236 8151 -65085
=============================================
- Hits 113896 1658 -112238
+ Misses 420984 41089 -379895
+ Partials 13342 232 -13110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
It would be nice if someone could test this using RPM, since I have not tested installing the RPM packages. |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@blueorangutan package |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
I can give it a quick look, @JoaoJandre . Do you need more then just a monkey test, i.e. specific functional tests? Or do you have a scripted version of the tests to perform? |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19791 |
@DaanHoogland
Honestly my main concern is just if the guestfish is being correctly installed when the RPMs are installed. The rest should work. |
|
@blueorangutan test keepEnv |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-17312) |
|
[SF] Trillian Build Failed (tid-17315) |
|
[SF] Trillian Build Failed (tid-17317) |
|
@JoaoJandre , not sure if this is because the lab is to busy or a real failure. I'll have to abandon it for a while, sorry. |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@blueorangutan package |
|
@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 20080 |
|
@blueorangutan test |
|
@RosiKyu a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-17586) |
|
@JoaoJandre I tested this on a KVM lab (Oracle Linux 9, advanced zone) with KBOSS, first on 24.0 without this PR, then the PR packages. The agent package installs Two questions:
Also noticed:
Thanks! |
@RosiKyu Regarding your first question, these APIs were not included in the default roles, but custom roles can add permission for the APIs. Regarding your second question, you got it correctly, you can list the filesystems/files of a backup regardless of the configuration, but you cannot download a file unless the offering allows it, this is intended. For the page, pagesize and keyword, I believe these parameters should not be available in these APIs. Since guestfish does not support pagination, we would have to get everything from the backup anyway and filter it inside ACS. I will remove these parameters from these two APIs. For your last note, could you give me an example (with reproducible steps) of when does this happen? |
Description
This PR adds backup file extraction feature. Currently only supported by KBOSS.
This feature must be enabled in the backup offering through the
allowextractfileparameter. If it is set totrue, it will be possible to extract files from backups created with that offering.The
listBackupFilesystemsAPI was added to allow listing file systems inside backup volumes:backupIdvolumeIdExample execution of the
listBackupFilesystemsAPIThe
listBackupFilesAPI was added to allow listing files inside backup volumes:backupIdvolumeIdfilesystempathissymlinkThe
filesystemandpathparameters expect that the files do not contain special characters such as(,|, or>, for example. Both are expected to receive values in the format/path/to/something.Example execution of the
listBackupFilesAPITo download files, the
downloadBackupFileAPI was added:backupIdvolumeIdfilesystempathgzip; if it is a directory, it will be added to atararchive and compressed usinggzipThe
filesystemandpathparameters expect that the files do not contain special characters such as(,|, or>, for example. Both are expected to receive values in the format/path/to/something.Example execution of the
downloadBackupFileAPIThe list and download file workflow was also added to the GUI.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Test descriptions
isSymlink=trueflagisSymlinkflagAll the tests above were executed for both Linux ROOT volumes (ext4) and Windows ROOT volumes (NTFS).