Skip to content

make during-sync-call-no-sibling-resume.wast a bit more robust - #770

Merged
lukewagner merged 1 commit into
WebAssembly:mainfrom
dicej:tweak-during-sync-call-no-sibling-resume
Nov 19, 2026
Merged

lukewagner merged 1 commit into
WebAssembly:mainfrom
dicej:tweak-during-sync-call-no-sibling-resume

Conversation

@dicej

@dicej dicej commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Previously, the second test in that file was overly sensitive to how the runtime might schedule consecutive host->guest calls and any threads they might spawn. Specifically, it assumed that, if the first of two calls does a thread.resume-later, the second call would run before that thread resumes. I don't believe there's anything in the spec that requires that behavior, and indeed I'm working on a Wasmtime patch which breaks that assumption.

My solution is to refactor the test a bit so that there's only one host->guest call, and the rest is taken care of inside the guest.

Previously, the second test in that file was overly sensitive to how the runtime
might schedule consecutive host->guest calls and any threads they might spawn.
Specifically, it assumed that, if the first of two calls does a
`thread.resume-later`, the second call would run before that thread resumes.  I
don't believe there's anything in the spec that requires that behavior, and
indeed I'm working on a Wasmtime patch which breaks that assumption.

My solution is to refactor the test a bit so that there's only one host->guest
call, and the rest is taken care of inside the guest.
@dicej
dicej requested a review from lukewagner November 18, 2026 23:09
@lukewagner

Copy link
Copy Markdown
Member

Makes sense, thanks!

@lukewagner
lukewagner merged commit 585526a into WebAssembly:main Nov 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants