Repository navigation
make during-sync-call-no-sibling-resume.wast a bit more robust - #770
Merged
lukewagner merged 1 commit intoNov 19, 2026
Merged
Conversation
Previously, the second test in that file was overly sensitive to how the runtime might schedule consecutive host->guest calls and any threads they might spawn. Specifically, it assumed that, if the first of two calls does a `thread.resume-later`, the second call would run before that thread resumes. I don't believe there's anything in the spec that requires that behavior, and indeed I'm working on a Wasmtime patch which breaks that assumption. My solution is to refactor the test a bit so that there's only one host->guest call, and the rest is taken care of inside the guest.
Member
|
Makes sense, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the second test in that file was overly sensitive to how the runtime might schedule consecutive host->guest calls and any threads they might spawn. Specifically, it assumed that, if the first of two calls does a
thread.resume-later, the second call would run before that thread resumes. I don't believe there's anything in the spec that requires that behavior, and indeed I'm working on a Wasmtime patch which breaks that assumption.My solution is to refactor the test a bit so that there's only one host->guest call, and the rest is taken care of inside the guest.