Skip to content

Fix for call.without.effects in DAE2 - #9405

Draft
stevenfontanella wants to merge 1 commit into
mainfrom
dae2-call-without-effects
Draft

stevenfontanella wants to merge 1 commit into
mainfrom
dae2-call-without-effects

Conversation

@stevenfontanella

Copy link
Copy Markdown
Member

There's no need to note the special case of ref.func separately. If another function shares a type with the function that is the target of call.without.effects, it will anyway be optimized if the function is private and can't escape (e.g. if it never appears in a ref.func expression), and not optimized otherwise (whether callWithoutEffectsTypes is changed or not).

Fixes #9404.

Comment on lines +626 to +627
funcInfos[index].callWithoutEffectsTypes.insert(
target->type.getHeapType());

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not going to be thread-safe. We should instead collect the set of observed callWithoutEffects types on each function in parallel, then merge all the sets after the parallel pass.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DAE2 crashes on call.without.effects with a non ref.func expression

2 participants