Repository navigation
Fix for call.without.effects in DAE2 - #9405
Draft
stevenfontanella wants to merge 1 commit into
Draft
stevenfontanella wants to merge 1 commit into
stevenfontanella wants to merge 1 commit into
Conversation
tlively
reviewed
Nov 19, 2026
Comment on lines
+626
to
+627
| funcInfos[index].callWithoutEffectsTypes.insert( | ||
| target->type.getHeapType()); |
Member
There was a problem hiding this comment.
This is not going to be thread-safe. We should instead collect the set of observed callWithoutEffects types on each function in parallel, then merge all the sets after the parallel pass.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no need to note the special case of
ref.funcseparately. If another function shares a type with the function that is the target of call.without.effects, it will anyway be optimized if the function is private and can't escape (e.g. if it never appears in a ref.func expression), and not optimized otherwise (whether callWithoutEffectsTypes is changed or not).Fixes #9404.