Repository navigation
fix(push): stop scoped pushes before creating unlinked dependencies - #108
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
Devin Review🟢 Devin Review found nothing to fix · View findings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This closes the last gap after #104: a push scoped to one file no longer creates an unlinked dependency without an explicit flag.
Before:
npm run push -- acme resources/acme/assistants/receptionist.mdauto-applied an unlinkedtools/my-end-call.yml. The new-file check only looked at the paths given, so the push POSTed a new tool, even when the org already had a same-named one, and warned only afterwards.Now the preflight walks the dependencies the scoped push would auto-apply (
src/push-dependencies.ts), including squad → assistant → tool/structured output. Each unlinked one goes into the same grouped stop report (text and--json) with "Needed by " and the usual fixes:--adopt <id>,--allow-new-files, or delete. The push exits 1 before any write.--allow-new-filesapproves creation across the selected scope and its dependencies; dependency paths don't need to be listed.src/push-scope.tsso the preflight and the push share it.Example (scoped push, same-named org tool exists):
Docs: AGENTS.md (new-file check), README, commands/how-it-works guides, improvements.md.
Tests:
npm run build,npm test(614 pass), and Biome pass. Local-HTTP integration tests cover these cases: blocked with no non-GET requests, approved, adopted, linked, owned reuse, transitive, dry run, JSON, and inventory error. No live org was touched.