Repository navigation
docs(examples): two NHS practice squads sharing one assistant set - #100
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
Contributor
Devin Review🟢 Devin Review found nothing to fix · View findings |
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
changed the base branch from
feat/validate-undefined-variables
to
feat/blocks
November 21, 2026 00:27
devin-ai-integration Bot
added a commit
that referenced
this pull request
Nov 21, 2026
* feat(validate): warn on undefined squad variables Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * docs(examples): add shared NHS practice squads Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * fix(examples): inline practice-specific transfer destinations Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * fix(validate): reject Liquid transfer destination numbers Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * docs: explain squad variable and transfer number validation Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * docs: add shared practice quick reference Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * docs: link NHS example across stacked PR branches Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/nhs-shared-squads/is a worked version of the PRISM-2684 setup: two shared assistants and one shared handoff tool, used by two practice squads that differ only in theirmembersOverrides. Adding another practice means adding one more squad file.templates/blocks/nhs-test-{practice,handover}.md, from feat(blocks): shared prompt and config blocks, with a sync command #94). The model and voice are one config block,nhs-test-assistant.yml.tools:append, with literal numbers. The API rejects Liquid indestinations[].number(POST /toolreturns 400, even withnumberE164CheckEnabled: false), so a shared tool using{{urgent_handover_number}}isn't possible. feat(validate): catch undefined squad variables and Liquid transfer numbers #99 adds atransfer-number-liquidvalidate error for this. The handover numbers stay invariableValuesonly so the prompts can say them.variable-undefinedrule.npm run validate -- nhs-test --strictis clean. Removingpractice_mailboxfrom practice-b warns for practice-b's two members only.Based on
feat/blocks(#94, which now includes #99). No engine code changed.