Repository navigation
Make relative PYTHONPATH entries absolute at setup - #46
Merged
Merged
Conversation
VUnit starts vsim (Riviera-PRO, Questa/ModelSim) in the test output directory, so the embedded interpreter resolved relative entries there and could not import classes of Python objects found through them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VUnit starts vsim (Riviera-PRO, Questa/ModelSim) in the test output directory, while NVC and GHDL run in the directory VUnit was started in. The embedded interpreter resolves relative
PYTHONPATHentries against the simulator's working directory, so withPYTHONPATH=../models python run.pya Python object's class is found on NVC but not on Riviera-PRO:The setup now makes the entries of
PYTHONPATHabsolute against the current directory, the way python does (an empty entry becomes the current directory, as in CPython 3.10 and 3.12). A relativePYTHONPATHset in the run script afteradd_packageis still not covered; the docs say so and the recipe there already uses an absolute path.Verified:
PYTHONPATH+new_python_objecton Riviera-PRO 2026.04 (Linux): failed before, passes now; NVC passes both waystests/run.pyon NVC 136/137 with the one expected failure🤖 Generated with Claude Code